Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple change from str_ireplace to pref_replace for matching case sen… #17303

Merged

Conversation

tonypartridge
Copy link
Contributor

@tonypartridge tonypartridge commented Jul 27, 2017

Pull Request for Issue #17241

This stops the title replacements being replaced with the searched word and instead the actual word which is being replaced to be wrapped.

Summary of Changes

moved from str_ireplace
to preg_replace

Testing Instructions

Use joomla! com_search, search for a result which is is an uppercase with a lowercase letter i.e. Article is the title of the article search for article

Expected result

article and Article to be found but the hightlighted word to be case sensitive.

Actual result

The found match is replaced which the searched word.

…sitive and insensitive word replacements within the results.
@ghost
Copy link

ghost commented Jul 27, 2017

I have tested this item 🔴 unsuccessfully on eb31e8a

Searching for "Sample" (correct):

bildschirmfoto 2017-07-27 um 15 49 58

Searching for "sample" (not correct):

bildschirmfoto 2017-07-27 um 15 48 44


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.

@tonypartridge
Copy link
Contributor Author

@franz-wohlkoenig are you sure you applied the right patch?? Working on a fresh test here:
screenshot 2017-07-27 14 55 36

@ghost
Copy link

ghost commented Jul 27, 2017

I have tested this item ✅ successfully on eb31e8a

fetched Data again > works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.

@tonypartridge
Copy link
Contributor Author

Sorry @franz-wohlkoenig can you test again? :-) I've just added utf8/unicode support so we can use Arabic for example:

المستقبل

Many thanks
Tony

@ghost
Copy link

ghost commented Jul 27, 2017

I have tested this item ✅ successfully on fb7128e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on fb7128e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 27, 2017
@ghost
Copy link

ghost commented Jul 27, 2017

RTC after two successful tests.

@mbabker mbabker added this to the Joomla 3.8.0 milestone Jul 27, 2017
@mbabker mbabker merged commit fffdce9 into joomla:staging Jul 27, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 27, 2017
@nicksavov
Copy link
Contributor

I have tested this item ✅ successfully on fb7128e

One more for good measure 😃


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.

@tonypartridge
Copy link
Contributor Author

tonypartridge commented Jul 28, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants