-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple change from str_ireplace to pref_replace for matching case sen… #17303
Simple change from str_ireplace to pref_replace for matching case sen… #17303
Conversation
…sitive and insensitive word replacements within the results.
I have tested this item 🔴 unsuccessfully on eb31e8a Searching for "Sample" (correct):Searching for "sample" (not correct):This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303. |
I have tested this item ✅ successfully on eb31e8a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303. |
Sorry @franz-wohlkoenig can you test again? :-) I've just added utf8/unicode support so we can use Arabic for example: المستقبل Many thanks |
I have tested this item ✅ successfully on fb7128e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303. |
1 similar comment
I have tested this item ✅ successfully on fb7128e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303. |
RTC after two successful tests. |
I have tested this item ✅ successfully on fb7128e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303. |
Awesome! 😎
…On 28 Jul 2017, 21:07 +0100, Nick Savov ***@***.***>, wrote:
I have tested this item ✅ successfully on fb7128e
One more for good measure 😃
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Pull Request for Issue #17241
This stops the title replacements being replaced with the searched word and instead the actual word which is being replaced to be wrapped.
Summary of Changes
moved from str_ireplace
to preg_replace
Testing Instructions
Use joomla! com_search, search for a result which is is an uppercase with a lowercase letter i.e. Article is the title of the article search for article
Expected result
article and Article to be found but the hightlighted word to be case sensitive.
Actual result
The found match is replaced which the searched word.