Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allowedit for field group, only use component ACL if group ID is zero (new record) #17840

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

ggppdk
Copy link
Contributor

@ggppdk ggppdk commented Sep 2, 2017

Same fix as fix that had been applied here in the past to the article controller :

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/controllers/article.php#L80-L89

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/controllers/article.php#L112

Same as PRs
#17838
#17839

This is minor security issue,
if user than has "edit" on fields component, is denied editing configuration of a specific field group,
then user will still be able to edit the field group's configuration

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

@ggppdk ggppdk changed the title Fix allowEdit Fix allowedit for field group, only use component ACL if group ID is zero (new record) Sep 2, 2017
@sanderpotjer
Copy link
Member

I have tested this item ✅ successfully on 4ee0e26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17840.

1 similar comment
@Sieger66
Copy link
Contributor

I have tested this item ✅ successfully on 4ee0e26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17840.

@joomla-cms-bot joomla-cms-bot changed the title Fix allowedit for field group, only use component ACL if group ID is zero (new record) Fix allowedit for field group, only use component ACL if group ID is zero (new record) Sep 12, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging RTC This Pull Request is Ready To Commit and removed PR-staging labels Sep 12, 2017
@ghost
Copy link

ghost commented Sep 12, 2017

RTC after two successful tests.

@mbabker mbabker added this to the Joomla 3.8.1 milestone Sep 25, 2017
@mbabker mbabker merged commit 374a316 into joomla:staging Sep 25, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants