Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allowedit for field, only use component ACL if field ID is zero (new record) #17839

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

ggppdk
Copy link
Contributor

@ggppdk ggppdk commented Sep 2, 2017

Same fix as fix that had been applied here in the past to the article controller :

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/controllers/article.php#L80-L89

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/controllers/article.php#L112

Same as PRs
#17838
#17840

This is minor security issue,
if user than has "edit" on fields component, is denied editing configuration of a specific field ,
then user will still be able to edit the field's configuration

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

@sanderpotjer
Copy link
Member

I have tested this item ✅ successfully on b2167f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17839.

1 similar comment
@Sieger66
Copy link
Contributor

I have tested this item ✅ successfully on b2167f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17839.

@ghost
Copy link

ghost commented Sep 12, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 12, 2017
@mbabker mbabker added this to the Joomla 3.8.1 milestone Sep 25, 2017
@mbabker mbabker merged commit ee62311 into joomla:staging Sep 25, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants