Joomla 3.8.0: Disabled com_fields displayed in admin menu

[n3t]

Pull Request for Issue #18046 .

Summary of Changes

Added check to JAdminMenuCSS for disabled or not installed components.

Testing Instructions

Disable com_fields, and see the menu. Links to fields components are present, leading to 404 page.
Apply this patch, and see the menu again.

[waader]

I have tested this item ✅ successfully on 0e0bdbf

Thanks n3t, works great!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18134.}

[wojsmol]

@izharaazmi Please test this if you have a moment.

[izharaazmi]

I have tested this item ✅ successfully on 0e0bdbf

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18134.}

[ghost]

RTC after two successful tests.

[infograf768]

The problem with this code is that it increases drastically the queries.
Any better way? May be by specifically targeting com_fields ?

[izharaazmi]

@infograf768 What do you mean?

[alikon]

@izharaazmi see #18264

[infograf768]

I guess we could have done

			// Exclude item if com_fields component is not installed or disabled
			if ($item->element == 'com_fields' && (!JComponentHelper::isInstalled($item->element) || !JComponentHelper::isEnabled($item->element)))
			{
				continue;
			}

[izharaazmi]

Your suggestion only checks for com_fields, however the current code checks for all components and excludes a menu item if the related component is disabled/not installed.

[infograf768]

@izharaazmi
I tested disabling some components like com_associations, com_banners, etc., and it works fine with that code.
I suggest you test yourself.
com_fields is a specific case.

[izharaazmi]

Ok, I'll test it

[izharaazmi]

Okay. I tested it. The checks for items under component container are done internally so they are not needed, fine. For core (protected) components they cannot be disabled from UI, fine.

If we do have any other situation with any components we need this test for them. One such is com_fields. Since a custom menu can have any components link anywhere they will need this tests I think.

@infograf768 I think we must work to minimise the duplicate queries but restricting to com_fields does not seem right. What do you suggest?

[infograf768]

@izharaazmi
I suggest we discuss on #18264.
See my comment there #18264 (comment)
as I think that we may not really need to check if a comp is installed.