[JUX] Reducing language in admin mod_status #5

kyleledbetter · 2011-10-06T22:45:04Z

[JUX] Reducing language in admin mod_status to take less horizontal space

Signed-off-by: Kyle Ledbetter

…pace Signed-off-by: Kyle Ledbetter <kyle@kyleledbetter.com>

elinw · 2011-10-06T23:19:33Z

Kyle,

Can you please make a patch and post it in the joomlacode tracker since that is where the jbs looks for patches to test. Currently all commits are to be done via that route not by pull requests (though we all hope that is coming soon).

Thanks.

Elin

eddieajau · 2011-10-07T00:29:39Z

Do you know who's making the call on how to process direct pull requests? I understand the JBS workflow needs to be taken into account, but from the contributor side of things, it's sooo much easier to handle.

elinw · 2011-10-07T09:49:32Z

Speak with Mark.

infograf768 · 2011-10-09T15:53:42Z

Please post on joomlacode tracker. Closing request.

kyleledbetter · 2011-12-06T18:33:04Z

Hey all
Dang I'm so sorry, I wasn't getting my Github message notifications. From my understanding Github is now the main repo. Are we still required to go thru the joomlacode tracker?

realityking · 2011-12-06T19:42:54Z

Yes, for now the JBS keeps working with patches (svn style patch mind you). Only change is that the gibhup repro is now the point of truth.

To my knowledge we can use pull requests for feature patches, we're just not supposed to use them for issue stuff.

elkuku · 2011-12-06T21:01:55Z

One question..
Could we make a branch and submit the resulting diff link to the tracker ? this would ease the process (I think)..
I did this for tracker #27287 and it seems to work (committers satisfied), even with a git style patch ;)

realityking · 2011-12-06T21:21:19Z

I guess most of the time that should be fine. I usually just do a git diff --no-prefix to be save. Isn't really any slower either ;)

elkuku · 2011-12-06T21:28:51Z

What I mean is the diff link to the diff that is auto generated by GitHub.
e.g.: https://github.com/elkuku/joomla-cms/compare/com_users-login-fix.diff
which comes from: https://github.com/elkuku/joomla-cms/compare/com_users-login-fix
This would not include any history and such, but could be an interim solution until the committers feel comfortable with merging pull request (hopefully soonish)

realityking · 2011-12-06T21:37:36Z

Ah sorry misunderstood you. Well just try how well it works ;)

As far as I understand it the problem isn't really merging pull requests, it's testing them. And that is kinda painful, especially when you're not used to remotes and stuff.

elkuku · 2011-12-07T00:12:59Z

Testing patches ?
Well, this project deserves more attention (IMHO) https://github.com/ianmacl/patchtester

infograf768 · 2011-12-07T08:02:25Z

The point IMHO is not only testing a patch.
It is proposing modifications including important ones to be tested
for the same tracker/feature.
Proposals in github (comments incode. etc.) are just not fitting our needs.

NOTE: Concerning applying git-made .diff files using eclipse to an
SVN check-out, one has to simply set
"Ignore leading path name segements"
to 1

JM

Testing patches ?
Well, this project deserves more attention (IMHO)
https://github.com/ianmacl/patchtester

Reply to this email directly or view it on GitHub:
#5 (comment)

Please keep the Subject wording in your answers
This e-mail and any attachments may be confidential. You must not
disclose or use the information contained in this e-mail if you are
not the
intended recipient. If you have received this e-mail in error, please

notify us immediately and delete the e-mail and all copies.

Jean-Marie Simonet / infograf768
Joomla Production Working group
Joomla! Translation Coordination Team

Fix proposal for Featured Articles view

Update to Hathor

``` PHP Fatal error: Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Class PHP_CodeSniffer_CommentParser_ClassCommentParser not found' in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php:19 Stack trace: #0 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(1318): include_once() #1 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(560): PHP_CodeSniffer->registerSniffs(Array, Array) joomla#2 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(830): PHP_CodeSniffer->initStandard(Array, Array) joomla#3 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(95): PHP_CodeSniffer_CLI->process() joomla#4 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/scripts/phpcs(25): PHP_CodeSniffer_CLI->runphpcs() joomla#5 {main} thrown in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php on line 19 ```

* This is a combination of 8 commits. This is the 1st commit message: > First WIP version of supporting nested subforms. This is the commit message #2: > Fix nested subforms not getting correct name attribute on input fields. This is the commit message #3: > Fix subform rows having invalid index, fix small typo. This is the commit message #4: > Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process. This is the commit message #5: > Implement feedback from PR at Joomla; > - Use a <template> HTML element for the template of the subform rows, > not a url encoded string inside of a <script> element. > - Fix code style errors reported by phpcs. > - Make the fixing of the unique attributes (name, id, etc) of input elements > of nested subform rows more errorprone, using the same method as the main > subform row. > - Manually add a minified version of the javascript file. This is the commit message #6: > Fix failing javascript tests due to changed structure of subform repeatable template container. This is the commit message #7: > Change subform repeatable javascript test to correctly check on > 0-indexed rows, previously they have been 1-indexed. This is the commit message #8: > Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly. > Additionally added a note why the fixScripts() method is broken and how it could get better. * Commit code styling errors and add an aria label for the outermost 'add' button. * Fix double group-add button on repeatable subform type.

This is the 1st commit message: First WIP version of supporting nested subforms. This is the commit message joomla#2: Fix nested subforms not getting correct name attribute on input fields. This is the commit message joomla#3: Fix subform rows having invalid index, fix small typo. This is the commit message joomla#4: Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process. This is the commit message joomla#5: Implement feedback from PR at Joomla; - Use a <template> HTML element for the template of the subform rows, not a url encoded string inside of a <script> element. - Fix code style errors reported by phpcs. - Make the fixing of the unique attributes (name, id, etc) of input elements of nested subform rows more errorprone, using the same method as the main subform row. - Manually add a minified version of the javascript file. This is the commit message joomla#6: Fix failing javascript tests due to changed structure of subform repeatable template container. This is the commit message joomla#7: Change subform repeatable javascript test to correctly check on 0-indexed rows, previously they have been 1-indexed. This is the commit message joomla#8: Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly. Additionally added a note why the fixScripts() method is broken and how it could get better. This is the commit message joomla#9: First commit which integrates the subform custom field type. This is the commit message joomla#10: Rename manifest file for plg_fields_subform This is the commit message joomla#11: plg_fields_subform: Improve code comments and made the subform field type optionally non-repeatable. This is the commit message joomla#12: Fix not being able to change the type of a subfield. This is the commit message joomla#13: Implement a small in-memory renderCache for subform custom fields This is the commit message joomla#14: Prepare to load the subfields into a subform custom field directly via their own xml definition. This is the commit message joomla#15: After merge with PR joomla#17552 we can now successfully show the subforms options for the different types. This is the commit message joomla#16: The subform custom field type doesnt need a default value. This is the commit message joomla#17: Implement an option for a subform customfield to disable rendering the field values. This is the commit message joomla#18: Remove unused code and set hidden fields to not-required. This is the commit message joomla#19: Reset for dev

This is the 1st commit message: First commit which integrates the subform custom field type. This is the commit message joomla#2: Rename manifest file for plg_fields_subform This is the commit message joomla#3: plg_fields_subform: Improve code comments and made the subform field type optionally non-repeatable. This is the commit message joomla#4: Fix not being able to change the type of a subfield. This is the commit message joomla#5: Implement a small in-memory renderCache for subform custom fields This is the commit message joomla#6: Prepare to load the subfields into a subform custom field directly via their own xml definition. This is the commit message joomla#7: After merge with PR joomla#17552 we can now successfully show the subforms options for the different types. This is the commit message joomla#8: The subform custom field type doesnt need a default value. This is the commit message joomla#9: Implement an option for a subform customfield to disable rendering the field values. This is the commit message joomla#10: Remove unused code and set hidden fields to not-required.

First commit which integrates the subform custom field type. This is the commit message joomla#2: Rename manifest file for plg_fields_subform This is the commit message joomla#3: plg_fields_subform: Improve code comments and made the subform field type optionally non-repeatable. This is the commit message joomla#4: Fix not being able to change the type of a subfield. This is the commit message joomla#5: Implement a small in-memory renderCache for subform custom fields This is the commit message joomla#6: Prepare to load the subfields into a subform custom field directly via their own xml definition. This is the commit message joomla#7: After merge with PR joomla#17552 we can now successfully show the subforms options for the different types. This is the commit message joomla#8: The subform custom field type doesnt need a default value. This is the commit message joomla#9: Implement an option for a subform customfield to disable rendering the field values. This is the commit message joomla#10: Remove unused code and set hidden fields to not-required. Signed-off-by: Rene Pasing <r.pasing@continga.de>

Joomla 3.9.0 Part #5

Metismenu frontend

Week 1: Generate responsive images

Thank you!

[JUX] Reducing language in admin mod_status to take less horizontal s…

e2e0342

…pace Signed-off-by: Kyle Ledbetter <kyle@kyleledbetter.com>

infograf768 closed this Oct 9, 2011

cspratt mentioned this pull request Feb 5, 2012

Finder / Smart Search Index Hangs on Large Content Sites #121

Closed

davidhurley pushed a commit that referenced this pull request Oct 9, 2013

Merge pull request #5 from beat/jux-actions-fix

1f708e8

Fix proposal for Featured Articles view

mbabker pushed a commit that referenced this pull request Mar 10, 2014

Merge pull request #5 from wilsonge/patch-5

185546a

Update to Hathor

Bakual referenced this pull request in Bakual/joomla-cms May 12, 2014

Merge pull request #5 from wilsonge/patch-5

f328913

Update to Hathor

thinkerytim mentioned this pull request Feb 2, 2015

redirect plugin unknown column header error #5953

Closed

maxdel85 mentioned this pull request Mar 6, 2015

Error redirect #6333

Closed

Pikkolo mentioned this pull request Apr 14, 2015

Whenever trying to create a new menu voice #6778

Closed

sovainfo mentioned this pull request Apr 15, 2015

[fix] getMessage doesn't exist, use getError instead. #6783

Closed

tgv604 mentioned this pull request May 28, 2015

restricted Contact page displays error stack instead of 404 or 403 error page #7053

Closed

tallandtrue mentioned this pull request Nov 7, 2018

[4.0] Could not connect to database during installation #22956

Closed

wilsonge added a commit that referenced this pull request Mar 27, 2019

Merge pull request #24371 from wilsonge/joomla390-merge5

5d85b08

Joomla 3.9.0 Part #5

dginevaAxway mentioned this pull request Oct 11, 2019

Problem with plugin: CAPTCHA - reCAPTCHA - RFC standard violation in reCAPTCHA #26546

Closed

grantg182 mentioned this pull request Oct 29, 2019

Error: Failed to start application: Failed to start application #26861

Closed

toivo mentioned this pull request May 4, 2020

[4.0] Converting several mails to mail templates #28722

Merged

15 tasks

toivo mentioned this pull request May 27, 2020

[4.0]Feed Display module uncaught error in rss.xml feed #29236

Closed

hans2103 referenced this pull request in hans2103/joomla-cms Aug 10, 2020

Merge pull request #5 from hans2103/metismenu-frontend

c27d13a

Metismenu frontend

cloudfaction mentioned this pull request Mar 22, 2021

Update to J4 gives error JEventDispatcher when searching site #32805

Closed

joomdonation mentioned this pull request Apr 15, 2021

[4.0] Review UX of subform Custom Field #28389

Closed

eyvazahmadzada pushed a commit to eyvazahmadzada/joomla-cms that referenced this pull request Jul 15, 2021

Merge pull request joomla#5 from joomla-projects/week1

f89c34c

Week 1: Generate responsive images

boris-grinac mentioned this pull request Dec 18, 2021

Joomla 4.04: upgrade to 4.05 fails, upgrade process freezes with now messages #36349

Closed

oorzaak mentioned this pull request Apr 15, 2022

Frontend editable module of "Custom" type cannot be saved anymore #37438

Open

DonPedro34 mentioned this pull request Jun 3, 2022

When using the Joomla 4 API to Create an Article it fails (500) as soon as an Editor Plugin is installed #37975

Closed

siriusmedia-cu mentioned this pull request Jul 26, 2022

Multilingual Associations infinitely reloads with checked-out items #38327

Open

roscofil mentioned this pull request Sep 13, 2022

[RESOLVED] Apparent login module crash when upgrading Joomla 4 website to php 8.0 #38749

Closed

qublibjohnny mentioned this pull request Feb 6, 2023

Symfony Fatal Error ErrorHandler.php #39804

Closed

ahotzler mentioned this pull request Apr 19, 2023

Error "setcookie(): Expects exactly 3 arguments when argument #3 ($expires_or_options) is an array" when Cookie Lifetime in Language Filter is set to Year #40421

Closed

Breiti85 mentioned this pull request Oct 19, 2023

[4.4.0] Joomla\CMS\Mail\MailerFactory::createMailer(): Return value must be of type Joomla\CMS\Mail\MailerInterface, Joomla\CMS\Mail\Mail returned #42164

Closed

Scrabble96 mentioned this pull request Oct 31, 2023

[5.0] Empty field value is rendering with added spaces in html so element is not :empty #42259

Closed

LadySolveig pushed a commit to LadySolveig/joomla-cms that referenced this pull request Jan 30, 2024

Merge pull request joomla#5 from coolcat-creations/macjoom-dark-ccc

ab165f4

Thank you!

alecrespi78 mentioned this pull request Apr 17, 2024

Update Sites - Joomla! Core (Could not load root metadata) #43287

Closed

ivanti mentioned this pull request May 22, 2024

Internal server error when choosing an image #43510

Open

robertparts mentioned this pull request Jun 20, 2024

Field Groups - search by ID: #43679

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JUX] Reducing language in admin mod_status #5

[JUX] Reducing language in admin mod_status #5

kyleledbetter commented Oct 6, 2011

elinw commented Oct 6, 2011

eddieajau commented Oct 7, 2011

elinw commented Oct 7, 2011

infograf768 commented Oct 9, 2011

kyleledbetter commented Dec 6, 2011

realityking commented Dec 6, 2011

elkuku commented Dec 6, 2011

realityking commented Dec 6, 2011

elkuku commented Dec 6, 2011

realityking commented Dec 6, 2011

elkuku commented Dec 7, 2011

infograf768 commented Dec 7, 2011

notify us immediately and delete the e-mail and all copies.

[JUX] Reducing language in admin mod_status #5

[JUX] Reducing language in admin mod_status #5

Conversation

kyleledbetter commented Oct 6, 2011

elinw commented Oct 6, 2011

eddieajau commented Oct 7, 2011

elinw commented Oct 7, 2011

infograf768 commented Oct 9, 2011

kyleledbetter commented Dec 6, 2011

realityking commented Dec 6, 2011

elkuku commented Dec 6, 2011

realityking commented Dec 6, 2011

elkuku commented Dec 6, 2011

realityking commented Dec 6, 2011

elkuku commented Dec 7, 2011

infograf768 commented Dec 7, 2011

notify us immediately and delete the e-mail and all copies.