Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_menus] Hide Process button when in Trashed status (Admin menu) #18195

Merged
merged 2 commits into from
Oct 5, 2017

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Oct 2, 2017

PR for #15134

This PR will ensure that the Process button is hidden (I have no idea why you cant batch process trashed items and that is beyond the scope of this PR)

Steps to reproduce the issue

Create an Administrator menu.
Create a menu item in this Administrator menu.
Trash this menu item.
Click Search Tools button.
Select Trashed in - Select Status - dropdown.
Select the Administrator menu in - Select Menu - dropdown.
Click Select All checkbox.
Click Batch button.

Expected result

Cancel button only.

Actual result

hide-process-button

PR for joomla#15134

This PR will ensure that the Process button is hidden (I have no idea why you cant batch process trashed items and that is beyond the scope of this PR)

### Steps to reproduce the issue
Create an Administrator menu.
Create a menu item in this Administrator menu.
Trash this menu item.
Click `Search Tools` button.
Select `Trashed` in `- Select Status -` dropdown.
Select the Administrator menu in `- Select Menu -` dropdown.
Click `Select All` checkbox.
Click `Batch` button.

### Expected result
Cancel button only.

### Actual result
![hide-process-button](https://cloud.githubusercontent.com/assets/368084/24762083/24eafaaa-1aa2-11e7-8bc4-188e20869f02.jpg)
@Quy
Copy link
Contributor

Quy commented Oct 2, 2017

I have tested this item 🔴 unsuccessfully on e370db1

The Process button is still displayed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18195.

@Quy
Copy link
Contributor

Quy commented Oct 2, 2017

I have tested this item ✅ successfully on 9301fdb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18195.

@ghost
Copy link

ghost commented Oct 3, 2017

I have tested this item ✅ successfully on 9301fdb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18195.

@ghost
Copy link

ghost commented Oct 3, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 3, 2017
@mbabker mbabker added this to the Joomla 3.8.2 milestone Oct 5, 2017
@mbabker mbabker merged commit 0b0e70e into joomla:staging Oct 5, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 5, 2017
@brianteeman
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants