Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin menu module - fix preset modern for postgresql #18537

Merged
merged 1 commit into from Nov 24, 2017

Conversation

csthomas
Copy link
Contributor

@csthomas csthomas commented Nov 9, 2017

Summary of Changes

Fix sql error in postgresql database in admin menu.

Testing Instructions

Error exists only on postgresql.

Before patch

jpeek0

After patch

jpeek1

@alikon
Copy link
Contributor

alikon commented Nov 9, 2017

I have tested this item ✅ successfully on 1471f13


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18537.

@csthomas
Copy link
Contributor Author

As my change is equal to the same line in

sql_group="a.id, m.language, l.image"

another test may be done by code review or by test on mysql only.

@ghost
Copy link

ghost commented Nov 19, 2017

I have tested this item ✅ successfully on 1471f13

System information

3.8.3-dev
Multilanguage Site (4 Lang.) & Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)

MAMP 4.2

  • PHP 7.0.22
  • MySQLi 5.6.35

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18537.

@ghost
Copy link

ghost commented Nov 19, 2017

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 19, 2017
@mbabker mbabker added this to the Joomla 3.8.3 milestone Nov 24, 2017
@mbabker mbabker merged commit 9b479c9 into joomla:staging Nov 24, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Nov 24, 2017
@csthomas csthomas deleted the pgsql_admin_menu_modern branch November 24, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants