Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Load language files when needed in dispatcher #19810

Closed
wants to merge 2 commits into from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Mar 2, 2018

Load the language in the dispatch function and not before.

Can be merged on review @wilsonge.

@laoneo laoneo changed the title [4.0] Simplify dispatcher code and load language files when needed [4.0] Load language files when needed in disptacher Mar 2, 2018
@joomla-cms-bot joomla-cms-bot changed the title [4.0] Load language files when needed in disptacher [4.0] Load language files when needed in dispatcher Mar 2, 2018
@wilsonge
Copy link
Contributor

wilsonge commented Mar 2, 2018

This actually needs to be moved higher up if we're now going to put the dispatcher in the component container.

@laoneo
Copy link
Member Author

laoneo commented Mar 2, 2018

Agree, if #19811 get merged, then I will move it up.

@wilsonge
Copy link
Contributor

wilsonge commented Mar 4, 2018

OK Im definitely going to be merging that so I'm just going to close this for now and let's move it to the final correct place once it's merged :)

@wilsonge wilsonge closed this Mar 5, 2018
@wilsonge wilsonge deleted the j4/dispatcher/simplify branch March 5, 2018 20:00
@wilsonge
Copy link
Contributor

wilsonge commented Mar 5, 2018

Closing this as we've merged #19811 and so this isn't the correct place anymore. Obviously will accept a PR putting it in the new(TM) correct place :p

@laoneo laoneo restored the j4/dispatcher/simplify branch March 6, 2018 06:45
@laoneo
Copy link
Member Author

laoneo commented Mar 6, 2018

Having a second look on it. Do we really want to load the language while booting the component? Mostly the language files are needed while dispatching the component. If we load it during boot and do not dispatch the component , the language files are loaded for nothing.

@wilsonge
Copy link
Contributor

wilsonge commented Mar 6, 2018

Yes because if you get a model instance then we still (unfortunately) queue up error messages, so right now we have to I think

@laoneo laoneo deleted the j4/dispatcher/simplify branch May 22, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants