[4.0] Load the component dispatcher through the ComponentInterface #19811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nents/service/dispatcher # Conflicts: # libraries/src/Application/CMSApplication.php # libraries/src/Application/CMSApplicationInterface.php # libraries/src/Application/CliApplication.php # libraries/src/Application/ConsoleApplication.php # libraries/src/Categories/Categories.php # libraries/src/MVC/Model/BaseDatabaseModel.php
laoneo
force-pushed
the
j4/components/service/dispatcher
branch
from
61f2348
to
d442435
Compare
wilsonge
reviewed
Mar 3, 2018
| $container->set('categories', ['' => new Category]); | ||
| $container->set(Categories::class, ['' => new Category]); | ||
|
|
||
| $container->set(DispatcherFactoryInterface::class, new DispatcherFactory('\\Joomla\\Component\\Content')); |
There was a problem hiding this comment.
We should be able to access frontend and backend dispatchers here I think
There was a problem hiding this comment.
You mean without a factory? I had that on a first version but moved to a factory because we will not be able to inject the application from the ComponenHelper, instead of its the one from the container. It leads then to an assumption that the app in the ComponentHelper is the same as in the container.
There was a problem hiding this comment.
No I'm just being stupid :)
This was referenced Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing effort to migrate the component services to the
ComponentInterface.The dispatcher is created by a an injected factory in the
ComponentInterface.