Change spacer's tooltip from tooltip to popover

[Quy]

Pull Request for Issue #19604 .

Summary of Changes

Change spacer's tooltip from tooltip to popover to match the other form fields.

Testing Instructions

Edit file \administrator\components\com_content\models\forms\article.xml
Change line 847 from:

		<field
			name="spacer1"
			type="spacer"
			hr="true"
		/>

to:

		<field
			name="spacer1"
			type="spacer"
			label="Label"
			description="This is a description"
		/>

Log in the backend
Edit an article
Under Images and Links, hover over Label

Expected result

Tooltip as popover

Actual result

Tooltip as tooltip

Documentation Changes Required

none

[infograf768]

Works fine here.
before

after

Please correct JFormFieldSpacerTest.php (line 122) as Travis is not happy ;)

[carlitorweb]

-------BEFORE--------

--------AFTER--------

[carlitorweb]

I have tested this item ✅ successfully on bffb7dd

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.}

[SharkyKZ]

RTC?

[infograf768]

Relaunched Travis

[infograf768]

This PR is now useless. popovers have been implemented since.
Closing.

[SharkyKZ]

This PR is fine. Spacer does not have popovers in current staging.

[infograf768]

reopening, but we have issues with tests in Travis.

[SharkyKZ]

Need to update test.

joomla-cms/tests/unit/suites/libraries/joomla/form/fields/JFormFieldSpacerTest.php

Lines 121 to 123 in bffb7dd

	$equals = '<span class="spacer"><span class="before"></span><span>' .
	'<label id="spacer-lbl" class="hasTooltip" title="&lt;strong&gt;spacer&lt;/strong&gt;">spacer</label></span>' .
	'<span class="after"></span></span>';

[infograf768]

@Quy
Can you modify the test file?

[SharkyKZ]

I have tested this item ✅ successfully on 40d0517

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.}

[SharkyKZ]

This issue is still closed on the Issue Tracker.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.}

[infograf768]

Reopened as pending on Issues Tracker and relaunched Drone.

[infograf768]

I have tested this item ✅ successfully on 40d0517

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.}

[infograf768]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.}

[infograf768]

@mbabker
I guess this can go in stable as totally B/C