Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap field descriptions 'user registration' (frontend) and 'user mana… #21961

Closed
wants to merge 1 commit into from
Closed

Swap field descriptions 'user registration' (frontend) and 'user mana… #21961

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 2, 2018

…gement' (backend)

All field descriptions for optional fields in 'user registration' are "If required, please fill this field." This has no meaning to a regular user.
In addition to that this description exists only once for all fileds. (not usable)
On the other hand there is a single description for each optional user field in 'user management' which is unnecessary for admins or publishers.
So my solution was to change line 259 in profile.php
from: if ($app->isClient('site')...
to: if (!$app->isClient('site')...
This solved the problem (at least in my case).

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

…gement' (backend)

All field descriptions for optional fields in 'user registration' are "If required, please fill this field." This has no meaning to a regular user.
In addition to that this description exists only once for all fileds. (not usable)
On the other hand there is a single description for each optional user field in 'user management' which is unnecessary for admins or publishers.
So my solution was to change line 259 in profile.php
from: if ($app->isClient('site')...
to: if (!$app->isClient('site')...
This solved the problem (at least in my case).
Mike
@SharkyKZ
Copy link
Contributor

SharkyKZ commented Sep 2, 2018

With this change, the description from plugin configuration is shown. E.g. Choose an option for the field Address 1. This is not correct, IMO, as it refers to the required/optional/disabled options from plugin config.

@brianteeman
Copy link
Contributor

@SharkyKZ is correct

@ghost
Copy link
Author

ghost commented Sep 2, 2018

So what would you suggest ? (Or do you doubt the problem ?)

@ghost
Copy link
Author

ghost commented Sep 2, 2018

Things get mor funny !
I just made some screenshots after selecting English as default language.
Forget about the backend - Frontend is more impotant.
Screenshots 1 (line 259 in profile.php CHANGED)
(In this case I can change these descriptions by language override)
frontend_w_patch

Screenshots 2 (line 259 in profile.php UNCHANGED)
(In this case I can't change these descriptions by language override)
frontend_wo_change

I hope you now can see what I mean !?

@brianteeman
Copy link
Contributor

As explained by @SharkyKZ it refers to the required/optional/disabled options from plugin config.

@ghost
Copy link
Author

ghost commented Sep 2, 2018

Sorry, but what does that mean to me ?
Do I get my problem solved or not ?
What else can I do to have a different description field popup for each field (as in my screenshots 1)?

@brianteeman
Copy link
Contributor

It means your proposed solution is not correct.

Personally I would not use that plugin. You can achieve what you want with custom fields.

@ghost
Copy link
Author

ghost commented Sep 3, 2018

@brianteeman

Personally I would not use that plugin

If I got it right, you say I should not use Joomla - because it's the original Joomla plugin what we are talking about here !

You can achieve what you want with custom fields

Do you mean I should replace the original Joomla 'Users -> Manage -> Users:Edit -> User Profile' fields by 'Users -> Manage -> Users:Fields' ?

@brianteeman
Copy link
Contributor

If the plugin does not suit your needs then yes I would create the fields using Users -> Manage -> Users:Fields'

@ghost ghost closed this Sep 3, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants