New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Implement the workflow into the multilang sample data #21968
Conversation
Can you update this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve the language changes
I have tested this item 🔴 unsuccessfully on 356e15d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21968. |
In fact (not taking into account the transitions which should be the same as Joomla default imho), is missing the article set in _workflows_associations. In my POC I had added in
In this case with this new workflow, the value has to change in I do not see the reason to create a specific workflow per language btw. |
The last commit did not go through last night..... I recommited it, should be fixed now. |
This corrects now the status of articles. Tks. |
For stages the same applies as here. For The workflow itself...I have no feelings if there should be one for each language or one in general...It's just a matter of moving the creation outside of the foreach... |
Simple is better. Call it "Sample Multilingual Workflow" and out the foreach. :) |
I have tested this item ✅ successfully on 83b0f51 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21968. |
I have tested this item ✅ successfully on 83b0f51 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21968. |
Ready to Commit after two successful tests. |
Please be nice to drone. Param $itemlanguage is no more. :)
|
@bembelimen |
@bembelimen Why was this closed? |
Ooops, I deleted the branch accidently, here is the PR again: #22123 |
Pull Request for Issue #21707 . (second part)
Summary of Changes
This PR let the multilang sample data creating a new Workflow to ensure, that the articles are published
Testing Instructions