[4.0] Implement the workflow into the blog sample data #21953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infograf768
reviewed
Sep 2, 2018
plugins/sampledata/blog/blog.php
Outdated
|
|
||
| $workflow = [ | ||
| 'title' => Text::_('PLG_SAMPLEDATA_BLOG_SAMPLEDATA_CONTENT_WORKFLOW_0_TITLE'), | ||
| 'description' => Text::_('PLG_SAMPLEDATA_BLOG_SAMPLEDATA_CONTENT_WORKFLOW_0_DESCRIPTION'), |
brianteeman
reviewed
Sep 2, 2018
| @@ -26,6 +26,8 @@ PLG_SAMPLEDATA_BLOG_SAMPLEDATA_CONTENT_ARTICLE_5_INTROTEXT="<p>Templates control | |||
| PLG_SAMPLEDATA_BLOG_SAMPLEDATA_CONTENT_ARTICLE_5_TITLE="Your Template" | |||
| PLG_SAMPLEDATA_BLOG_SAMPLEDATA_CONTENT_CATEGORY_0_TITLE="Blog" | |||
| PLG_SAMPLEDATA_BLOG_SAMPLEDATA_CONTENT_CATEGORY_1_TITLE="Help" | |||
| PLG_SAMPLEDATA_BLOG_SAMPLEDATA_CONTENT_WORKFLOW_0_DESCRIPTION="A sample workflow for the blog sample datas" | |||
1 task
|
Removed my last comment as it was on the wrong branch |
|
Assuming that the new workflow will get the full set of stages and workflows when the other pr is merged this is working correctly. If you can confirm that assumption I can mark a successful test |
|
Yes, that's true |
|
I have tested this item ✅ successfully on 13450bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21953. |
|
Sorry, which other PR? I am lost here. |
|
I have tested this item ✅ successfully on 13450bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21953. |
|
Ready to Commit after two successful tests. |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Sep 8, 2018
* Implement the workflow into the blog sample data * Tabs => Spaces * Typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #21707 . (first part)
Summary of Changes
This PR let the blog sample data creating a new Workflow to ensure, that the articles are published
Testing Instructions
Apply the "Blog Sample data" and check the workflows, a new workflow called "Sample Workflow" is created and assigned to all new sample data categories.