Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] Repeatable field - calendar field type #22415

Closed
pepperstreet opened this issue Sep 27, 2018 · 14 comments
Closed

[3.9] Repeatable field - calendar field type #22415

pepperstreet opened this issue Sep 27, 2018 · 14 comments

Comments

@pepperstreet
Copy link

Is your feature request related to a problem? Please describe.

Current repeatable field allows to use the following field types:
Editor
Media
Number
Text
TextArea

A date input helper is missing. The core form field Calendar could be added to the list.
Example use cases: Enter multiple, re-occurring event dates; CV dates like education times, or working locations with time frames.

Describe the solution you'd like

Type parameter should list a calendar field type to allow input of accurate dates.

Additional context / Related question

BTW, the sub-fields do not allow any further customization. No options can be set. Are there any thoughts on this or any technical approach...? For instance, set the editor to use a certain profile and toolbar; reduce the calendar display options; format the date; etc.

@AndySDH
Copy link
Contributor

AndySDH commented Oct 19, 2018

To be fair, all Field Types should be added to the list for Repeatable Field (#20243). There is a case use for all of them. So other than Calendar, also List, Radio, Checkboxes, Colour, User, etc, all of them should be available.

And yes, all Fields should also come with with their respective options that they each have. So the maximum length, the filter for text, the editor options for editor, etc.

It should essentially be a SubFields creations inside one Field.

Also, as @woluweb suggested previously, it would be cool to be able to select from already existing fields instead of "creating" one.

Another issue, a Media field should output the img tag like a normal Media Field does, not the image path, not sure why it outputs the image path in the repeatable field.

@roland-d

@continga
Copy link

@AndySDH Yeah, all(!) what you are describing is exactly what we have in #22446 . Lets keep the discussion there, so I think this issue can be closed (as we have a PR?)

@AndySDH
Copy link
Contributor

AndySDH commented Oct 19, 2018

@contiga Sure! Just as long as we make sure to keep it under one field. So let's revamp upon the repeatable field, no need for a separate one :)

@continga
Copy link

I agree 😄

@roland-d
Copy link
Contributor

What we really need is not only support for more fields but that you can choose an already existing custom field.

@AndySDH
Copy link
Contributor

AndySDH commented Oct 19, 2018

You know, @continga, supporting existing custom fields would make it even MUCH MORE EASIER. So you don't have to replicate all the settings for each field inside the field creation, you just use the ones from existing fields.

@mbabker
Copy link
Contributor

mbabker commented Oct 19, 2018 via email

@AndySDH
Copy link
Contributor

AndySDH commented Oct 19, 2018

@mbabker Right! We'll probably ending up renaming this while we are at it.

@continga
Copy link

continga commented Oct 19, 2018

#22446 is actually supporting custom field types. There is no limitation on the nested field types (besides they shouldn't be subforms themselfes, see https://github.com/joomla/joomla-cms/pull/22446/files#diff-cb0a6f090d20a596a5a809a8d1653294R39 ). What the plugin basically is doing is loading all available field types into the selection. I think I need to write documentation for it, as describing its functionality in GitHub issues seems a bit odd. How would I do that? Just create a new wiki page in the docs and make clear it is for my PR?

@continga
Copy link

Maybe I misunderstood the "already existing custom field" sentence. We really need to work on the word choices... Confusing. I thought you were talking about custom field types (as per, plugins installed from the JED e.g.), not about already existing custom fields

@AndySDH
Copy link
Contributor

AndySDH commented Oct 19, 2018

Maybe I misunderstood the "already existing custom field" sentence. We really need to work on the word choices... Confusing. I thought you were talking about custom field types (as per, plugins installed from the JED e.g.), not about already existing custom fields

Right yes. The idea is use already existing Custom Fields.

  • So first create an actual separate custom field with whatever field type, settings and display options.
  • Then create a subform/subfield and load that into it.

Would make it more easy and also can save some time. Say you need to re-use a custom field in multiple subforms. You create it only once and then you can load it into different subforms/subfields.
What do you think?

@AndySDH
Copy link
Contributor

AndySDH commented Oct 19, 2018

Let's move discussion over at #22446

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/22415

@ghost
Copy link

ghost commented Apr 2, 2019

closed as Discussion is on #22446. Please reopen if i'm wrong.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22415.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants