Multilang: correcting Published Request Form Menu Item url in Privacy Dashboard
#22909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2018
Quy
reviewed
Nov 2, 2018
| @@ -92,28 +87,67 @@ public function getRequestFormPublished() | |||
|
|
|||
| $db = $this->getDbo(); | |||
| $query = $db->getQuery(true) | |||
| ->select($db->quoteName('id')) | |||
| ->select($db->quoteName('id') . ', ' . $db->quoteName('published') . ', ' . $db->quoteName('language')) | |||
There was a problem hiding this comment.
Suggested change
| ->select($db->quoteName('id') . ', ' . $db->quoteName('published') . ', ' . $db->quoteName('language')) | |
| ->select($db->quoteName(array('id', 'published', 'language'))) |
|
I have tested this item ✅ successfully on 7d2fb99 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22909. |
|
I have tested this item ✅ successfully on 7d2fb99 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22909. |
|
RTC. Thanks for testing. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22909. |
mbabker
reviewed
Jan 5, 2019
|
No need to ask for new tests. Works fine here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #22869 (comment)
Summary of Changes
Correct the link (language included) and the
Published/Unpublishedstatus of thePublished Request Form Menu Itemurl, making it totally independent of the site default language when we do have such menu items.Also when we have no menu item, correcting the
Itemidto use the default site language home page one instead of the one set to ALL languages.Testing Instructions
See #22869 (comment)
Test and test2.
SEF off to see the non-sef url.
After patch
When we have one or multiple menu items:
The url obtained will anyway be the one of the lowest id in case there are multiple menu items of this kind (no change there as we have only one line for an url in the dashboard), but at least:
The
Itemidand the language will be the correct ones in case there are multiple menu items, this independantly from the site default language.Example when there is a fr-FR such menu item
Also, when there is NO menu item, the Itemid used will not be anymore the
Itemidof the default home page set to ALL languages, but the one of the default home page for the default site language. That is important concerning modules assignment.Example when French is default language and the French home page Itemid is 105 while the home set to ALL is 101.
Before patch
After patch
@mbabker