Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy dashboard: direct access to the privacy consent plugin #22888

Merged
merged 4 commits into from Jan 11, 2019

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 commented Oct 31, 2018

Pull Request for Issue #22869

Summary of Changes

Adds direct link to the privacy consent plugin when there is no Privacy policy article defined.

Testing Instructions

make sure no article is defined in the Privacy Consent System plugin parameters

Before patch

No link to the plugin (and no idea what to do when getting The "Not available" button...)

After patch

screen shot 2018-10-31 at 12 13 02

The only other hyperlink for a chack check that "could" be also added is one to the Global Configuration for mailonline, but this is rather obvious.
For menus, it is also quite obvious.
Can be added though if judged necessary in another PR.

@brianteeman
Copy link
Contributor

Not everything should have a link. The similar module for mutilingual status does not.

@PhilETaylor

This comment was marked as abuse.

@alikon
Copy link
Contributor

alikon commented Oct 31, 2018

not so bad imo to guide more newbie's....
already collected similar question's

@PhilETaylor

This comment was marked as abuse.

@Bakual
Copy link
Contributor

Bakual commented Oct 31, 2018

Reopening as I also don't see a reason to close this. I guess it was by accident.

@Bakual Bakual reopened this Oct 31, 2018
@brianteeman
Copy link
Contributor

Sorry it was closed by accident

@infograf768
Copy link
Member Author

@PhilETaylor
I reopened #22869 as we need to discuss there what we do for the other checks.
I propose we treat this one separately, get it tested (please do) and merged in the mean while.

@infograf768
Copy link
Member Author

#22909
is a totally independant PR to correct the Published Request Form Menu Item url in multilang

*/
public static function getPrivacyConsentPluginId()
{
$db = JFactory::getDbo();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please use namespaced version here and where needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alikon
done. Please test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alikon
Copy link
Contributor

alikon commented Jan 9, 2019

I have tested this item ✅ successfully on d618c8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22888.

1 similar comment
@chmst
Copy link
Contributor

chmst commented Jan 10, 2019

I have tested this item ✅ successfully on d618c8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22888.

@infograf768
Copy link
Member Author

rtc
tks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22888.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 10, 2019
@infograf768 infograf768 added this to the Joomla 3.9.2 milestone Jan 10, 2019
@infograf768
Copy link
Member Author

@mbabker
I leave this as RTC as the last change was just a missing s in the lang string.
(Tks Mig for finding this typo)

@mbabker mbabker merged commit b5200b4 into joomla:staging Jan 11, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 11, 2019
@infograf768 infograf768 deleted the privacydashboardpolicycheck branch January 11, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants