Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question. Why is $category->title prepared by content plugins? #22941

Closed
ReLater opened this issue Nov 5, 2018 · 3 comments
Closed

Question. Why is $category->title prepared by content plugins? #22941

ReLater opened this issue Nov 5, 2018 · 3 comments

Comments

@ReLater
Copy link
Contributor

ReLater commented Nov 5, 2018

Small performance issue.

Does anybody know the reason why category titles are prepared by content plugins here:
https://github.com/joomla/joomla-cms/blob/3.9.0/layouts/joomla/content/category_default.php#L55-L59
?

@ReLater
Copy link
Contributor Author

ReLater commented Nov 5, 2018

Would it be a B\C break to just escape them like other titles?

@Bakual
Copy link
Contributor

Bakual commented Nov 5, 2018

The question is not if it is a B/C break if you remove an existing plugin event. It is.
The right question would what the use case is for this event. It's likely to alter the title in some ways (eg attaching an icon to it?) or do some other complex stuff based on category title.

@ReLater
Copy link
Contributor Author

ReLater commented Nov 5, 2018

I didn't find a use case in core.

But if it's a B\C break it's not worth to talk about.

@ReLater ReLater closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants