[3.9] Fix navigating to the first page in pagination when SEF is off #23042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #22983
Summary of Changes
Reverted a few lines added in the previous PR #19467
Changed the unit test method
JPaginationTest::buildLink($url)
to better emulateRouter::build($url)
, where empty parameters such as&limitstart=
are always removed from the URL.Testing Instructions
Test #22983 when SEF is ON and OFF.
Expected result
You can back to the first page in pagination when SEF is OFF.
Actual result
When SEF is OFF the
limitstart
parameter remains in the link to the first page and you can not back to the first page.Documentation Changes Required
No