[4.0] Remove obsolete menu class "nav-pills" from menu modules' parameters and contact links

[richard67]

Pull Request for Issue #23023 .

Summary of Changes

Remove the obsolete menu class "nav-pills" from contact default links markup and blog sampledata plugin menu creation.

Testing Instructions

Code review for the sample data part, patch tester and check that contact links look like without this PR for the contact links part.

Expected result

The menu class "nav-pills" is not added in blog sample data for menus at module position "top-a", e.g. the "Main Menu Blog", and also not added to the markup of the contact links list (<ul> element).

Actual result

The menu class "nav-pills" is added in blog sample data for menus at module position "top-a", e.g. the "Main Menu Blog", but it has no effect.
This might confuse administrators who create or maintain menu modules.
The CSS class nav-pills" is also added to the markup of the contact links list (<ul> element), but it has no effect there because the links list doesn't have an active element on which the pills effect should be applied.

Documentation Changes Required

None.

[richard67]

@ciar4n Could you review or test this PR?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.}

[ciar4n]

The reason for nav-pills not working from the database should not apply here.

[richard67]

Well, but this class has no effect in the Cassiopeia template. Compare the look of contact links with and without nav-pills, and you will not see any difference. That's why I think it should be removed here, too.

[ciar4n]

I see now. Bootstraps nav-pills class applies the pill effect to 'active' items only. There is no 'active' items in this list so you are correct.

[ciar4n]

I have tested this item ✅ successfully on 152e183

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.}

[richard67]

@ciar4n Could you set your test result again? It has been reset by branch update to latest 4.0-dev. There have not been made any changes. Thanks in advance.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.}

[ciar4n]

I have tested this item ✅ successfully on 9c2f072

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.}

[richard67]

Thanks a lot. Hope we find a 2nd tester.

[richard67]

@ciar4n Sorry, could you set your test result again? I had again to update branch. Thanks in advance.
@Quy Do you have time and mood to test this PR?

[infograf768]

I have tested this item ✅ successfully on 5dcd2da

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.}

[infograf768]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.}

[infograf768]

Updated @ciar4n test result in Issues.
Relaunched Travis to try to make it pass as the analysis4x issue is not related.

[richard67]

@infograf768 Thanks a lot.

[infograf768]

@richard67
Maybe you have time to test:
#23143 (RTL stuff too)

[wilsonge]

Thanks guys! Sorry for the delay on merging