Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix markup #23080

Merged
merged 1 commit into from Nov 15, 2018
Merged

[4.0] Fix markup #23080

merged 1 commit into from Nov 15, 2018

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Nov 15, 2018

Summary of Changes

Add closing ".

Testing Instructions

Code review.
or
Log in the backend and view page source.

Expected result

<span class="fa-fw fa fa-home" aria-hidden="true">

Actual result

See missing " after fa-home.

<span class="fa-fw fa fa-home aria-hidden="true">

@Quy Quy changed the title Fix markup [4.0] Fix markup Nov 15, 2018
@richard67
Copy link
Member

I have tested this item ✅ successfully on d9e7b2e

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23080.

@PhilETaylor

This comment was marked as abuse.

@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23080.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 15, 2018
@laoneo laoneo added this to the Joomla 4.0 milestone Nov 15, 2018
@laoneo laoneo merged commit a3489b6 into joomla:4.0-dev Nov 15, 2018
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Nov 15, 2018
@Quy Quy deleted the patch-1 branch November 15, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants