-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Unix Domain Socket for memcache and memcached Sessions. #24073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@loureirorg please test > https://docs.joomla.org/Testing_Joomla!_patches |
Why is this PR on 3.9-dev and not on staging? |
You are right, this should be staging. |
@tht2p @datsepp Please test. |
Change memcache(d) minimum allowed server port number to zero for socket connections
@zero-24 are you interested to merged this or should I close it? |
Have noted it for 3.10.6 but will not merge it into 3.10.5 as we are in RC mode already. |
Merging here. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #23761 .
Summary of Changes
Only set memcache port number if its greater then 0
Testing Instructions
Set session handling to memcache and/or memcached (2 different extensions for PHP) and use a UDS path to connect to memcached (Daemon).
Expected result
Login still works
Documentation Changes Required
Using memcache with UDS set the port to 0.