Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Preview button translated twice #24173

Merged
merged 4 commits into from Mar 15, 2019

Conversation

hardik-codes
Copy link
Contributor

@hardik-codes hardik-codes commented Mar 12, 2019

Summary of Changes

Correcting double translation of the Preview button`

Testing Instructions

In the articles overview, open any article

Expected result

See the Preview button in the toolbar buttons
untranslated2

Actual result

untranslated1

Documentation Changes Required

None

@hardik-codes
Copy link
Contributor Author

@infograf768 thanks

@hardik-codes
Copy link
Contributor Author

Members please test this PR.

@infograf768
Copy link
Member

In fact, it is translated, but twice...
pr solves that

@ghost
Copy link

ghost commented Mar 13, 2019

@hardik-codes can you please correct Title according Comment above?

@hardik-codes
Copy link
Contributor Author

@hardik-codes can you please correct Title according Comment above?

which comment are you referring to @franz-wohlkoenig ?

@ghost
Copy link

ghost commented Mar 13, 2019

#24173 (comment)

As far as i understood its not about "Preview button is now translated" its about "In fact, it is translated, but twice..."

@infograf768 infograf768 changed the title [4.0] Preview button is now translated [4.0] Preview button translated twice Mar 13, 2019
@infograf768
Copy link
Member

Corrected title and description

@infograf768
Copy link
Member

I have tested this item ✅ successfully on e261db4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24173.

@hardik-codes
Copy link
Contributor Author

@franz-wohlkoenig please test this PR

@Quy
Copy link
Contributor

Quy commented Mar 13, 2019

I have tested this item ✅ successfully on e261db4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24173.

@Quy
Copy link
Contributor

Quy commented Mar 13, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24173.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 13, 2019
@wilsonge wilsonge merged commit 9b9c33d into joomla:4.0-dev Mar 15, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 15, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 15, 2019
@hardik-codes hardik-codes deleted the untranslated-String branch April 18, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants