[4.0] Untranslated strings???

[brianteeman]

Steps to reproduce the issue

Enable debug language
All strings should be wrapped in **
Observe how many of the button are wrapped in ?? indicating untranslated but they are
I don't know if its a bug in the debug code or what

Examples

[SharkyKZ]

It means the string is translated multiple times.

[infograf768]

For Preview, it is quite simple

It is first translated in
https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Toolbar/ToolbarButton.php#L121
as every toolbar button by default

Then it is translated again in
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/View/Article/HtmlView.php#L197-L200

This one can be solved here by modifying this last one to

				$url = PreviewHelper::url($this->item);
				$toolbar->preview($url, 'JGLOBAL_PREVIEW')
					->bodyHeight(80)
					->modalWidth(90);

to get

I could not find a way for Change Status

[hardik-codes]

Started working on this.

[puneeth2001]

@SharkyKZ are you sure that this is being caused by repetition of strings, I can find the repetetion
in the 'preview' thing as @infograf768 said but couldn't find the repetetion in case of Change Status.

[puneeth2001]

I found these being called only once, i.e. in plugins/sampledata/blog/blog.php

[SharkyKZ]

Site menus are not translatable.

are you sure that this is being caused by repetition of strings

Yes, it's because Joomla\CMS\Toolbar\Button\DropdownButton::prepareOptions() calls parent::prepareOptions() which translates the string and then uses the options to create a new button. But new button expects an untranslated string.

joomla-cms/libraries/src/Toolbar/Button/DropdownButton.php

Line 70 in 96b325c

$button = new BasicButton($this->getName(), $this->getText(), $options);

[infograf768]

Indeed
$this->getText() also uses Text::_

[puneeth2001]

ok I get it thanks.

[infograf768]

Preview double translation now solved:
#24178

Remains Change Status if it can be done.

[ghost]

@infograf768 Issue stay open?

[infograf768]

remains the Change Status issue to solve, if possible.

[brianteeman]

@infograf768

Preview double translation now solved:
#24178

That's not the right PR?

[infograf768]

The right PR was #24173

Reopening as Change Status issue is not solved yet.

[brianteeman]

Closing - not worth keeping it open for this edge case.