Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinderController duplicate lines #244

Closed
okonomiyaki3000 opened this issue Jun 18, 2012 · 2 comments
Closed

FinderController duplicate lines #244

okonomiyaki3000 opened this issue Jun 18, 2012 · 2 comments

Comments

@okonomiyaki3000
Copy link
Contributor

In FinderController (/components/com_finder/controller.php), the following lines appear twice:

    // Load plug-in language files.
    FinderHelperLanguage::loadPluginLanguage();

First on lines 43+44 then immediately after on lines 46+47.

Also, line 41 sets $user = JFactory::getUser(); but $user is never used in this function so the line can be removed.

@infograf768
Copy link
Member

Please create a trcaker on joomlacode and cross reference here

@okonomiyaki3000
Copy link
Contributor Author

dneukirchen pushed a commit to dneukirchen/joomla-cms that referenced this issue Sep 28, 2017
* Mock file system for foo plugin
Can be deleted safely

* Added multiple file system support for controller

* Added multiple file system support for API

* Injected adapter info to config params

* Added config params to Local File System Plugin

* Foo file system plugin(mock file system)

* Syntax fixup

* Syntax fixup

* added errorCode for exception

* code fixup

* optimizations

* indention fixes

* added errorCode 500

* Added getProviders method and used Joomla\Registry\Registry

* removed getProviders method

* used namespaced classes

* used namespaced classes

* Added translatable texts

* Added translatable texts

* updated indention

* removed redundant strings

* improved readability

* fixed indention

* fixed issue with config

* added invalid argument exception

* removed redundant function

* moved getAdapter method to Model

* created media view model

* removed defaultFileSystem config

* Created new Model and moved getProviders method to it

* used media model

* fixed indention

* removed account handling

* used providers

* added new line at end

* fixed issue

* added new line at end

* removed old implementation

* added new line

* added new line

* removed unused var

* removed unused var

* changed from crlf to lf

* changed from crlf to lf

* changed from crlf to lf

* changed from crlf to lf
hans2103 added a commit to hans2103/joomla-cms that referenced this issue Nov 18, 2020
joomla#242 revert removal of `id="back-top"` to prevent `#top` in the url after clicking back-top
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants