[4.0] Fix batch copy for articles #24519

Arpit-24 · 2019-04-06T18:35:30Z

Pull Request for Issue #24478 .

Summary of Changes

Add workflow_assosciations entry for the new articles

Testing Instructions

Install sample data
Select all articles
Select batch
Select a category and copy

Expected result

Articles are copied to the selected category

4.0 dev

Hides the header and options in full screen mode to prevent overlap over the editor area in full-screen mode. Another possible alternative is displaying both the options as well as the editor in full-screen mode but purely a user preference. Because the need for save and other options is not as important in full-screen mode.

4.0 dev

merge

4.0 dev

Arpit-24 · 2019-04-06T18:39:26Z

Testing Result

ghost · 2019-04-07T05:26:26Z

I have tested this item 🔴 unsuccessfully on 5528b0e

Article copied successfully, but open a Categorie got Warning: Declaration of Joomla\Component\Categories\Administrator\Model\CategoryModel::batchCopy($value, $pks, $contexts) should be compatible with Joomla\CMS\MVC\Model\AdminModel::batchCopy($value, $workflowid, $pks, $contexts) in /administrator/components/com_categories/Model/CategoryModel.php on line 39

Maybe this Pull Request can not be tested by Patchtester.

System information

Setting	Value
PHP Built On	Linux lamp122.cloudaccess.net 3.10.0-962.3.2.lve1.5.24.7.el6h.x86_64 nr.1 SMP Mon Dec 17 12:02:35 EST 2018 x86_64
Database Type	mysql
Database Version	5.7.24-cll-lve
Database Collation	utf8_general_ci
Database Connection Collation	utf8_general_ci
PHP Version	7.1.26
Web Server	Apache
WebServer to PHP Interface	cgi-fcgi
Joomla! Version	Latest Nightly Build Update from Joomla! 4.0.0-alpha8-dev Development [ Amani ] 9-March-2019 13:41 GMT
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:66.0) Gecko/20100101 Firefox/66.0

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24519.}

infograf768 · 2019-04-07T06:24:43Z

Looks like the problem here is that modifying the Joomla\CMS\MVC\Model\AdminModel::batchCopy by adding $workflowid may be used by another component extending AdminModel, while it concerns only articles.
Therefore categories get warning as well as com_fields. We get errors for contacts, etc.

bembelimen · 2019-04-07T13:11:50Z

If you have the old ID, you don't need this parameter. One can just get the default stage from the workflow (linked in the new category) when copied, so the article is resetted or just don't change anything when moved.

Arpit-24 · 2019-04-07T14:21:22Z

If you have the old ID, you don't need this parameter. One can just get the default stage from the workflow (linked in the new category) when copied, so the article is resetted or just don't change anything when moved.

Thank you for the help, updated the PR. Now it no longer has the additional param of workflow_id in the function definition.

@franz-wohlkoenig @infograf768 Please re-test

bembelimen · 2019-04-07T15:03:10Z

libraries/src/MVC/Model/AdminModel.php

+				->where($db->quoteName('item_id') . ' = ' . $pk);
+			$db->setQuery($query);
+
+			$results = $db->loadObjectList();


->loadObject()

Made the required changes

bembelimen · 2019-04-07T15:03:51Z

libraries/src/MVC/Model/AdminModel.php

+			$query->clear()
+				->insert($db->quoteName('#__workflow_associations'))
+				->columns(array($db->quoteName('item_id'), $db->quoteName('stage_id'), $db->quoteName('extension')))
+				->values($newId . ', ' . $old_stage_id . ', \'' . $oldExtension . '\'');


->quote(...)

Changing this actually gives error in my PC

->values($db->quote($newId) . ',' . $db->quote($old_stage_id) . ',' . $db->quote($oldExtension)); does it here. See my zip below.

bembelimen · 2019-04-07T15:05:46Z

libraries/src/MVC/Model/AdminModel.php

+			$query = $db->getQuery(true)
+				->select($db->quoteName(array('stage_id','extension')))
+				->from($db->quoteName('#__workflow_associations'))
+				->where($db->quoteName('item_id') . ' = ' . $pk);


Missing context/extension

I am afraid I don't understand what you mean

bembelimen · 2019-04-07T15:08:47Z

administrator/templates/atum/scss/template.scss

No need to add this changes here.

@bembelimen
In fact, is indeed missing a ending return for this file in core.

Co-Authored-By: Quy <quy@fluxbb.org>

administrator/components/com_content/Model/ArticleModel.php

Co-Authored-By: Quy <quy@fluxbb.org>

Nilesh5995 · 2019-10-19T10:42:38Z

I have tested this item ✅ successfully on 62a78a1

I have tested this item successfully

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24519.}

Schmidie64 · 2019-10-19T11:49:41Z

I have tested this item ✅ successfully on 62a78a1

Work's as described.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24519.}

conseilgouz · 2019-10-19T11:49:52Z

I have tested this item ✅ successfully on 62a78a1

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24519.}

pascalelocher · 2019-10-19T12:38:37Z

I have tested this item ✅ successfully on 62a78a1

PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24519.}

adiheutschi · 2019-10-19T12:40:36Z

I have tested this item ✅ successfully on 62a78a1

Success

Setting Value
PHP Built On Linux server2.adiheutschi.ch 3.10.0-962.3.2.lve1.5.24.9.el7.x86_64 #1 SMP Wed Feb 13 08:24:50 EST 2019 x86_64
Database Type mysql
Database Version 10.2.27-MariaDB
Database Collation latin1_swedish_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 7.3.10
Web Server LiteSpeed
WebServer to PHP Interface litespeed
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24519.}

alikon · 2019-10-20T14:36:07Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24519.}

richard67 · 2019-10-29T09:23:08Z

I've stumpled over the issue which is fixed by this PR and so found this PR and checked in detail what it does. To be honest: I am not really happy with it.

It overrides the batchCopy routine of the base class with (except of a few codestyle enhancements) identical code just to add then the creation of the workflow association record. This produces duplicate code.

Wouldn't it not be easier just to add following code to routine cleanupPostBatchCopy in the article model below line 92, i.e. after the if with the sql insert of the new record into the #__content_frontpage table (which should also be changed bit that's another issue)?

		// Copy workflow association
		$workflow = new Workflow(['extension' => 'com_content']);
		$assoc = $workflow->getAssociation($oldId);
		$workflow->createAssociation($newId, (int) $assoc->stage_id);

These 3 lines should lead to the same result as this PR does.

Folks, please comment, maybe I am wrong or am missing some aspect of it.

infograf768 · 2019-10-31T07:19:35Z

@bembelimen
Please check this and infograf768#55 as we are not sure about handling workflow for this.

richard67 · 2019-11-13T10:45:18Z

Please test PR #26835 . Is solves the same problem as this PR here, but in a more elegant way.

wilsonge · 2019-11-13T12:09:11Z

Closing in favour of #26835 which uses the API and doesn't require full method duplication

Arpit-24 and others added 14 commits March 24, 2019 02:41

Merge pull request #1 from joomla/4.0-dev

86115e9

4.0 dev

Move tinymce change to it own file

8e99112

Move tinymce change to it own file

618b947

Merge branch '4.0-dev' into 4.0-dev

c64bf2d

Restore original file

e6d3c7d

Restore file

7deff97

Fix Joomla logo to center

6d90683

Restore

63f7b59

Merge pull request #3 from joomla/4.0-dev

03fc4a7

4.0 dev

Merge pull request #4 from joomla/4.0-dev

13e1e3f

4.0 dev

Merge pull request #6 from joomla/4.0-dev

293c974

merge

Merge pull request #7 from joomla/4.0-dev

0453d1a

4.0 dev

Fix batch copy for Articles

c7509f0

joomla-cms-bot added the PR-4.0-dev label Apr 6, 2019

Arpit-24 added 4 commits April 7, 2019 00:12

Add comment

bdabec8

Align comments

a710743

Fix drone comment

81f9397

Interchange comments

5528b0e

Quy mentioned this pull request Apr 6, 2019

[4.0] Batch copy fails #24478

Closed

Remove additional workflow_id param

473997c

bembelimen reviewed Apr 7, 2019

View reviewed changes

Arpit-24 and others added 3 commits July 13, 2019 19:26

Update administrator/components/com_content/Model/ArticleModel.php

1ecee0e

Co-Authored-By: Quy <quy@fluxbb.org>

Update administrator/components/com_content/Model/ArticleModel.php

b5c9a87

Co-Authored-By: Quy <quy@fluxbb.org>

Update administrator/components/com_content/Model/ArticleModel.php

027d560

Co-Authored-By: Quy <quy@fluxbb.org>

Quy reviewed Jul 13, 2019

View reviewed changes

administrator/components/com_content/Model/ArticleModel.php Outdated Show resolved Hide resolved

Update ArticleModel.php

a371afe

Quy reviewed Jul 13, 2019

View reviewed changes

administrator/components/com_content/Model/ArticleModel.php Show resolved Hide resolved

infograf768 and others added 4 commits July 14, 2019 08:05

Merge branch '4.0-dev' into 4.0-batch-copy

cb8931a

Merge branch '4.0-dev' into 4.0-batch-copy

99a22e2

Update administrator/components/com_content/Model/ArticleModel.php

a2b3e66

Co-Authored-By: Quy <quy@fluxbb.org>

Update ArticleModel.php

bea51de

Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jul 20, 2019

Merge branch '4.0-dev' into 4.0-batch-copy

b9b4d6f

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 20, 2019

This was referenced Oct 28, 2019

[4.0] Batch copy workflow association, too infograf768/joomla-cms#55

Merged

[4.0] Fixing Articles batch copy #26835

Merged

Merge branch '4.0-dev' into 4.0-batch-copy

d8f5867

Merge branch '4.0-dev' into 4.0-batch-copy

d9734bd

Quy removed the RTC This Pull Request is Ready To Commit label Nov 3, 2019

Quy mentioned this pull request Nov 12, 2019

[4.0] batch content fails #27060

Closed

wilsonge closed this Nov 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.0] Fix batch copy for articles #24519

[4.0] Fix batch copy for articles #24519

Arpit-24 commented Apr 6, 2019

Arpit-24 commented Apr 6, 2019

ghost commented Apr 7, 2019 •

edited by ghost

infograf768 commented Apr 7, 2019 •

edited

bembelimen commented Apr 7, 2019

Arpit-24 commented Apr 7, 2019

bembelimen Apr 7, 2019

Arpit-24 Apr 7, 2019

bembelimen Apr 7, 2019

Arpit-24 Apr 7, 2019

infograf768 Apr 8, 2019

bembelimen Apr 7, 2019

Arpit-24 Apr 7, 2019

bembelimen Apr 7, 2019

infograf768 Apr 8, 2019

Nilesh5995 commented Oct 19, 2019

Schmidie64 commented Oct 19, 2019

conseilgouz commented Oct 19, 2019

pascalelocher commented Oct 19, 2019

adiheutschi commented Oct 19, 2019

alikon commented Oct 20, 2019

richard67 commented Oct 29, 2019

infograf768 commented Oct 31, 2019

richard67 commented Nov 13, 2019

wilsonge commented Nov 13, 2019

[4.0] Fix batch copy for articles #24519

[4.0] Fix batch copy for articles #24519

Conversation

Arpit-24 commented Apr 6, 2019

Summary of Changes

Testing Instructions

Expected result

Arpit-24 commented Apr 6, 2019

ghost commented Apr 7, 2019 • edited by ghost

System information

infograf768 commented Apr 7, 2019 • edited

bembelimen commented Apr 7, 2019

Arpit-24 commented Apr 7, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nilesh5995 commented Oct 19, 2019

Schmidie64 commented Oct 19, 2019

conseilgouz commented Oct 19, 2019

pascalelocher commented Oct 19, 2019

adiheutschi commented Oct 19, 2019

alikon commented Oct 20, 2019

richard67 commented Oct 29, 2019

infograf768 commented Oct 31, 2019

richard67 commented Nov 13, 2019

wilsonge commented Nov 13, 2019

ghost commented Apr 7, 2019 •

edited by ghost

infograf768 commented Apr 7, 2019 •

edited