New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.9.0 Part 14 #24555
Merged
Merged
3.9.0 Part 14 #24555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obvious. Merging.
* Links to buttons * Revert unused file
* Move duplicated code to the PrivacyPlugin * Code style
* Add action log plugin library class * Double * * register instead of import
This language string created by the JSST is not correct - see the style guide https://developer.joomla.org/en-gb-user-interface-text-guidelines/action-or-description.html
* Fix wrong action log link when add/edit article * Add @SInCE tag * Correct codestyle
* Sort log extensions * Case insensitive * Workaround. Thanks @mbabker.
Summary of Changes Removal of a redundant comment. Testing Instructions Code review to confirm it's not needed in the distribution.
… a (joomla#22518) module in frontend
3.9 Release Candidate
infograf768
reviewed
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes us upto 3.9.0 Release Candidate
Note always merge with a merge commit don't squash/rebase