Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] Revert #22367 #22506

Merged
merged 1 commit into from Oct 6, 2018
Merged

[3.9] Revert #22367 #22506

merged 1 commit into from Oct 6, 2018

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 commented Oct 5, 2018

Pull Request for Issue #20255

Summary of Changes

reverting still allows to use the Toolbar button when not scrolling and display the modals

@ciar4n
Copy link
Contributor

ciar4n commented Oct 5, 2018

You mean issue #22465 ?

This will not fix #20255

@infograf768
Copy link
Member Author

I am talking here about the discussion we had in #20255

@ciar4n
Copy link
Contributor

ciar4n commented Oct 5, 2018

I have tested this item ✅ successfully on ca9817e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22506.

@infograf768
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22506.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 5, 2018
@infograf768 infograf768 added this to the Joomla 3.9.0 milestone Oct 5, 2018
@mbabker mbabker merged commit 603d2e4 into joomla:staging Oct 6, 2018
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Oct 6, 2018
@infograf768 infograf768 deleted the static_revert branch January 25, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants