[4.0] Actions logs toolbar #24562
Merged
[4.0] Actions logs toolbar #24562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All components only have the options and help on the right hand side this PR brings the action logs component into sync
ghost
added
the
Quy
reviewed
Apr 12, 2019
| @@ -98,12 +98,12 @@ protected function addToolbar() | |||
| { | |||
| JToolbarHelper::title(JText::_('COM_ACTIONLOGS_MANAGER_USERLOGS'), 'list-2'); | |||
|
|
|||
| JToolbarHelper::deleteList('JGLOBAL_CONFIRM_DELETE', 'actionlogs.delete'); | |||
| JToolBarHelper::custom('actionlogs.exportSelectedLogs', 'download', '', 'COM_ACTIONLOGS_EXPORT_CSV', true); | |||
| JToolBarHelper::custom('actionlogs.exportLogs', 'download', '', 'COM_ACTIONLOGS_EXPORT_ALL_CSV', false); JToolbarHelper::deleteList('JGLOBAL_CONFIRM_DELETE', 'actionlogs.delete'); | |||
There was a problem hiding this comment.
Suggested change
| JToolBarHelper::custom('actionlogs.exportLogs', 'download', '', 'COM_ACTIONLOGS_EXPORT_ALL_CSV', false); JToolbarHelper::deleteList('JGLOBAL_CONFIRM_DELETE', 'actionlogs.delete'); | |
| JToolBarHelper::custom('actionlogs.exportLogs', 'download', '', 'COM_ACTIONLOGS_EXPORT_ALL_CSV', false); | |
| JToolbarHelper::deleteList('JGLOBAL_CONFIRM_DELETE', 'actionlogs.delete'); |
There was a problem hiding this comment.
No this was deliberate to put the delete actions at the end of the list see Banners/tracks as an example
There was a problem hiding this comment.
coding style: This is only moving JToolbarHelper::deleteList('JGLOBAL_CONFIRM_DELETE', 'actionlogs.delete'); to the next line and not be on the same line 102.
Quy
reviewed
Apr 12, 2019
administrator/components/com_actionlogs/views/actionlogs/view.html.php
Outdated
Show resolved
Hide resolved
…html.php Co-Authored-By: brianteeman <brian@teeman.net>
|
You could use Joomla\CMS\Toolbar\Toolbar; for Toolbar like in other views. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24562. |
|
I deliberately didn't do any namespacing here as it makes sense to do all of that in its own pr. Single purpose pr are much easier for people to test. |
|
I have tested this item ✅ successfully on 4236002 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24562. |
1 similar comment
|
I have tested this item ✅ successfully on 4236002 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24562. |
|
Status "Ready To Commit". |
|
Thanks! |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All components only have the options and help on the right hand side this PR brings the action logs component into sync
Before
After