Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Module edit. Dropdown Save&Close fails when module User Status deactivated #24921

Merged
merged 6 commits into from May 16, 2019
Merged

Conversation

ReLater
Copy link
Contributor

@ReLater ReLater commented May 16, 2019

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 67cfd27

Note: it is also needed for site modules edit if the User Status module is unpublished.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.

@ReLater
Copy link
Contributor Author

ReLater commented May 16, 2019

Note: it is also needed for site modules edit if the User Status module is unpublished.
I'll provide a pr.

@infograf768
Copy link
Member

We may improve this by also taking off the code from the User Status module as it will not be necessary anymore.

@infograf768
Copy link
Member

What I meant is that adding it in the edit.php as done here solves the issue for all modules edit, site and admin.

@ReLater
Copy link
Contributor Author

ReLater commented May 16, 2019

Yes, my #24921 (comment) was nonsense ;-)

@infograf768 infograf768 changed the title administrator module edit. Dropdown Save&Close fails when module User Status deactivated [4.0] Module edit. Dropdown Save&Close fails when module User Status deactivated May 16, 2019
@ReLater
Copy link
Contributor Author

ReLater commented May 16, 2019

We may improve this by also taking off the code from the User Status module as it will not be necessary anymore.

Let's do it in another pr after this one has been merged. There are several modules with line
HTMLHelper::_('bootstrap.framework'); in tmpl/default.php but I'm not sure if we need them for output and not just for edit purposes.

I've added a reminder to my ToDos.

@SharkyKZ
Copy link
Contributor

This should probably be added to dropdown button layout.

@ReLater
Copy link
Contributor Author

ReLater commented May 16, 2019

Moved fix to layouts/joomla/toolbar/dropdown.php

@SharkyKZ
Copy link
Contributor

I have tested this item ✅ successfully on aa70678


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.

1 similar comment
@Quy
Copy link
Contributor

Quy commented May 16, 2019

I have tested this item ✅ successfully on aa70678


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.

@Quy
Copy link
Contributor

Quy commented May 16, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 16, 2019
@wilsonge wilsonge merged commit 29ddc74 into joomla:4.0-dev May 16, 2019
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone May 16, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2019
@ReLater ReLater deleted the patch-2 branch May 16, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants