[4.0] Reminder due to pr #24921. Remove "HTMLHelper::_('bootstrap.framework');" from modules

[ReLater]

ToDo

• After pr [4.0] Module edit. Dropdown Save&Close fails when module User Status deactivated #24921 is merged check whick modules need line HTMLHelper::_('bootstrap.framework');
• See [4.0] Module edit. Dropdown Save&Close fails when module User Status deactivated #24921 (comment)

[richard67]

$ find ./administrator/modules/ -type f -exec grep -l "HTMLHelper::_('bootstrap.framework');" {} \;
./administrator/modules/mod_popular/tmpl/default.php
./administrator/modules/mod_sampledata/tmpl/default.php
./administrator/modules/mod_feed/tmpl/default.php
./administrator/modules/mod_status/tmpl/default.php
./administrator/modules/mod_logged/tmpl/default.php
./administrator/modules/mod_multilangstatus/tmpl/default.php
./administrator/modules/mod_latestactions/tmpl/default.php
./administrator/modules/mod_latest/tmpl/default.php
$

$ find ./administrator/modules/ -type f -exec grep -l "dropdown" {} \;
./administrator/modules/mod_menu/tmpl/default_submenu.php
./administrator/modules/mod_status/tmpl/default.php
$

Don't know if that helps.

[ReLater]

Finding is not the ""problem"" but to decide if Bootstrap is loaded also for functionalities of the HTML output of the modules.
I don't have the time at the moment to investigate that.

[richard67]

So it would need to compare the HTML output produced by the modules listed in my first listing with the content of the same modules when the HTMLHelper::_('bootstrap.framework'); has been removed, and if output is the same, then the line is obsolete, right? Or does it need more to be investigated?

[ReLater]

and if output is the same, then the line is obsolete, right?

Yes, if everything functions as before.

Even if I've learned Joomla 4 core doesn't need JQuery/Bootstrap-JS and everything in core will be replaced somehow by Vanilla scripts it looks like that this isn't the fact yet. Thus I'm in doubt if we can remove these lines.

[richard67]

I will see if I can find time. But if you find time before me or others, let us known here so we don't do double work.

[richard67]

@ReLater Meanwhile I am also in doubt if it is as easy as I assumed it to be. Do you know who could help us with that?

[ReLater]

Yes, not easy to test. Time-consuming.

I use a plugin that removes bootstrap-*.js in backend. Then compare the output plus functionalities of the backend modules with and without active plugin. I also deactivate other backend modules as far as possible.

First result: mod_popular doesn't need bootstrap.

BUT then I've found that /templates/atum/layouts/chromes/body.php DOESN'T load bootstrap-*.js but uses it for the edit cog dropdowns of modules. Thus it should load BS if we follow the common practice.

Now I think it's better to place a pr first for that find in body.php and ask for comments there if it's correct to add HTMLHelper::_('bootstrap.framework'); where it's missing AND (more important) if it's worth the time to investigate further for other files; instead of waiting.

See my related comment: "Even if I've learned Joomla 4 core doesn't need JQuery/Bootstrap-JS and everything in core will be replaced somehow by Vanilla scripts it looks like that this isn't the fact yet."

[ReLater]

Maybe @franz-wohlkoenig knows whom to ping?
I try @dgrammatiko , @wilsonge , @Bakual #24922 (comment)

[ghost]

@ReLater sorry, have no idea.

[brianteeman]

There is NO point looking at this until the new template is completed

[ReLater]

From my point of view modules should load their dependencies also with other templates but only if needed.

The main question is: Will be backend core extensions BS and Jquery free or not?

There is NO point looking at this until the new template is completed

Yes for chrome body.php. That's an atum layout. But not mod_popular.

[wilsonge]

The backend extensions will be jQuery (direct usages) free. However they won't be Bootstrap free from a CSS perspective. The aim is to make the backend not automatically load the javascript on all pages unless required.