New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Inline Messages/Alerts #25116
[4.0] Inline Messages/Alerts #25116
Conversation
In J4 we currently have two types of alert. One uses a custom element and is a "popup" the other is a regular div or "inline". This PR is to improve the accessibility of the inline messages/alerts. Currently we only convey the importance of the text by use of color which conveys no meaning for a color blind user. Accessibility golden rule is to never rely on just one visual indicator so this PR adds an icon. Secondly we need to convey the importance of the text to screen readers. The text alone is not always sufficient to do that so this PR adds a sr-only text
Co-Authored-By: Quy <quy@fluxbb.org>
I have tested this item ✅ successfully on 72ed01b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25116. |
In J4 we currently have two types of alert. One uses a custom element and is a "popup" the other is a regular div or "inline". This PR is to improve the accessibility of the popup messages/alerts. Currently we make use of color which conveys no meaning for a color blind user. Accessibility golden rule is to never rely on just one visual indicator so this PR adds an icon. This also makes the popup alerts consisten with the inline alerts updated joomla#25116 Finally the title of the popup used an H4. @zwiastunsw requested here joomla-projects/custom-elements#99 (comment) that this was not good for accessibility as the headings may not be nested correctly. So I have changed the H4 to a class=alert-heading (I have not customised the style of that class as it would be a waste of time as the admin template would change it) It can always be styled later This is based on the discussions joomla-projects/custom-elements#99
Related PR #25135 |
@richard67 That looks like an issue with com_patchtester not updating all the files - probably because there are so many. If you check the files changed you can see that neither of these have been forgotten. |
@brianteeman I think you are right, patchtester was a bit slow with this PR. Is of course your fault, you updated too many files 👅 (joke) . Beside this: I guess dgrammatiko 's comment in PR #25135 allso applies here, right? |
I have tested this item ✅ successfully on 72ed01b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25116. |
No his comment is wrong
…On Sun, 9 Jun 2019 at 12:37, Richard Fath ***@***.***> wrote:
I have tested this item ✅ successfully on 72ed01b
<72ed01b>
------------------------------
This comment was created with the J!Tracker Application
<https://github.com/joomla/jissues> at
issues.joomla.org/tracker/joomla-cms/25116.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25116?email_source=notifications&email_token=AAJ4P4KVUCDEOMDLTBQ3YTDPZTTOJA5CNFSM4HS2LXO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIIN4I#issuecomment-500205297>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJ4P4NHTPCMJZHFD7AJXITPZTTOJANCNFSM4HS2LXOQ>
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ <http://brian.teeman.net/>
|
@brianteeman I did not mean that he is right, I only meant that what he says he would say here, too. From my point of view, replacing fontawesome with inline svg or whatever else is subject of another, future PR, so I agree with you. |
@richard67 the decision was made that fontawesome would be supported in the admin iirc - @wilsonge can confirm |
@brianteeman I know, and saw meanwhile that this here is admin only, while other one was site, too. So I tested this here with success. It has 2 good tests now and could be set RTC. |
Status "Ready To Commit". |
Thank you |
Thanks |
In J4 we currently have two types of alert. One uses a custom element and is a "popup" the other is a regular div or "inline". This PR is to improve the accessibility of the inline messages/alerts.
Currently we only convey the importance of the text by use of color which conveys no meaning for a color blind user. Accessibility golden rule is to never rely on just one visual indicator so this PR adds an icon.
Secondly we need to convey the importance of the text to screen readers. The text alone is not always sufficient to do that so this PR adds a sr-only text
This is based on the discussions joomla-projects/custom-elements#99
Note: The icon could have been added just with css but as we were adding the sr-only text I couldnt see any advantage