Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][com_redirect] convert to prepared statement #25417

Merged
merged 10 commits into from
Jul 15, 2019
Merged

[4.0][com_redirect] convert to prepared statement #25417

merged 10 commits into from
Jul 15, 2019

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Jul 3, 2019

Summary of Changes

use prepared statement for SQL

Testing Instructions

test com_redirect

Expected result

should work as before

Actual result

N/A

@richard67
Copy link
Member

com_predirect? Is it a predictive redirect component? (joking about typo in title of this PR).

@alikon
Copy link
Contributor Author

alikon commented Jul 3, 2019

happy to see that even a draft + work in progress pull request got audience 😃

@alikon alikon changed the title [4.0][com_predirect][wip] convert to prepared statement [4.0][com_redirect][wip] convert to prepared statement Jul 3, 2019
@alikon alikon marked this pull request as ready for review July 3, 2019 17:35
@alikon alikon changed the title [4.0][com_redirect][wip] convert to prepared statement [4.0][com_redirect] convert to prepared statement Jul 3, 2019
@Quy
Copy link
Contributor

Quy commented Jul 3, 2019

Column count doesn't match value count at row 1

@Quy
Copy link
Contributor

Quy commented Jul 4, 2019

I have tested this item ✅ successfully on 72d6ef4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25417.

@tonypartridge
Copy link
Contributor

I have tested this item ✅ successfully on 72d6ef4

Working as before.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25417.

@ghost
Copy link

ghost commented Jul 13, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 13, 2019
@wilsonge wilsonge merged commit 3792350 into joomla:4.0-dev Jul 15, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 15, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jul 15, 2019
@alikon alikon deleted the patch-117 branch July 16, 2019 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants