-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0][com_redirect] convert to prepared statement #25417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Jul 3, 2019
Quy
reviewed
Jul 3, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
com_predirect? Is it a predictive redirect component? (joking about typo in title of this PR). |
happy to see that even a draft + work in progress pull request got audience 😃 |
alikon
changed the title
[4.0][com_predirect][wip] convert to prepared statement
[4.0][com_redirect][wip] convert to prepared statement
Jul 3, 2019
alikon
changed the title
[4.0][com_redirect][wip] convert to prepared statement
[4.0][com_redirect] convert to prepared statement
Jul 3, 2019
Quy
reviewed
Jul 3, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
|
Quy
reviewed
Jul 3, 2019
Quy
reviewed
Jul 4, 2019
Quy
reviewed
Jul 4, 2019
Quy
reviewed
Jul 4, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
I have tested this item ✅ successfully on 72d6ef4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25417. |
I have tested this item ✅ successfully on 72d6ef4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25417. |
Status "Ready To Commit". |
roland-d
reviewed
Jul 14, 2019
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
use prepared statement for SQL
Testing Instructions
test com_redirect
Expected result
should work as before
Actual result
N/A