Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Load JS message titles on login #25474

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Conversation

brianteeman
Copy link
Contributor

If you get an error on login eg by hitting login without filling any field then the resulting error message has an untranslatable and lowercase "error" as the title

This PR fixes that

For completeness, consistency and future proof I added the other error message strings

Before

image

After

image

If you get an error on login eg by hitting login without filling any field then the resulting error message has an untranslatable and lowercase "error" as the title

This PR fixes that

For completeness, consistency and future proof I added the other error message strings
@richard67
Copy link
Member

I have tested this item ✅ successfully on 2d37fac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25474.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Jul 9, 2019

I have tested this item ✅ successfully on 2d37fac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25474.

@alikon
Copy link
Contributor

alikon commented Jul 9, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25474.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 9, 2019
@wilsonge wilsonge merged commit 53d96a5 into joomla:4.0-dev Jul 9, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Jul 9, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 9, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jul 9, 2019
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the mon1 branch July 9, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants