restore.php update #25793
restore.php update #25793
Conversation
This commit syncs restore.php with the latest upstream development, including tentative PHP 7.4 support.
| @@ -8325,7 +9243,7 @@ public function __toString() | |||
| } | |||
| if (function_exists('wincache_refresh_if_changed')) | |||
| { | |||
| wincache_refresh_if_changed(array($filename)); | |||
| wincache_refresh_if_changed([$filename]); | |||
There was a problem hiding this comment.
@nikosdion this square array syntax requires php 5.4. this is obviously a problem for the 5.3 support - i can't see anywhere else you're using it though - so is it accidental or is restore.php now php 5.4+?
There was a problem hiding this comment.
There was a problem hiding this comment.
I've dropped PHP 5.3 support several months ago. Actually, I am not supporting anything older than PHP 5.6 since February. If you want to remove the square brackets you'll have to do it after applying this PR. I am not going back to supporting ancient PHP versions with a cumulative (that is, 5.3, 5.4 and 5.5 combined) market share under 10%. It makes no sense.
BTW: according to my stats, the only people really using PHP 5.3 are those stuck on ancient versions of Joomla. Use of PHP 5.3 in Joomla 3.9 is so low that it's not even statistically significant.
There was a problem hiding this comment.
That's fine. I believe this is the only place so for now it's an ok tradeoff to fix a single line and obviously we don't care in J4 because we're supporting 7.2+.
So if it's ok with you we'll amend here - where would you like the copyright change. top of file or in this class or both?
There was a problem hiding this comment.
Top of the file please. Thank you!
|
I tried to update update from 3.9.2 to 3.9.11 with this restore.php but failed with "Invalid Login". Also 3.9.11 to 3.9.11 doesn't work with the same error. Any idea? |
|
I need to update the JavaScript on com_joomlaupdate. I hadn't realised that the restore.php you had was truly ancient. However, there are two problems with that.
The latter issue is basically one of communication and you should be able to handle it. The first issue is, at the moment, a hard contribution block for me. If someone gives me instructions for automatically applying JS code style with phpStorm I can resume my contributions which require JavaScript changes. If you can't you either commit to accept my contributions despite JS code style errors OR you lose me as a contributor. Rule number 1 for keeping contributors is to not make them feel their time is not appreciated by the project. |
|
I think it's best if you just modify your current restore.php for PHP 7.4 compatibility and add a header notice. I'm not touching Joomla's JS code with a 30-foot pole seeing what kind of things its JS coding style wants me to do. |
|
Thank you for you try and I have the same opinion to make our restore.php php 7.4 compatible is a much safer and easier step then upgrading to your version. |
|
@HLeithner What about @nikosdion 's request for some JS code style docs? Do you know where to address that issue? Or could we link to some Hound docs in our docs? I don't want this to be ignored because don't want to block him and others from contributing. We currently have a lack of JS experts - I am pretty sure not one. Update: Ah, I see it's about PHP code style. But that doesn't change that we should not block people from contributing. |
This commit syncs restore.php with the latest upstream development, including tentative PHP 7.4 support.
See gh-25782 for context
Summary of Changes
Updates com_joomlaupdate's
restore.php. The main change you'll notice is tentative PHP 7.4 support. I call it tentative because at the time of this writing I do not have a working PHP 7.4 installation; I just followed the clues in the gh-25782 issue.Testing Instructions
Run an update.
Documentation Changes Required
No impact.