Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify only unblocked super users #25829

Merged
merged 6 commits into from Aug 19, 2019
Merged

notify only unblocked super users #25829

merged 6 commits into from Aug 19, 2019

Conversation

eshiol
Copy link
Contributor

@eshiol eshiol commented Aug 13, 2019

Summary of Changes

Fixed Privacy component sends GDPR requests to blocked super users

Testing Instructions

Create a blocked super user
Create a GDPR request

Expected result

The Privacy component sends GDPR requests only to unlocked users

Actual result

Privacy component sends GDPR requests to blocked super users

Documentation Changes Required

@eshiol
Copy link
Contributor Author

eshiol commented Aug 13, 2019

I propose to send notification only to super users with Receive System Emails = Yes
->where($db->quoteName('sendEmail') . ' = 1')

@zero-24
Copy link
Member

zero-24 commented Aug 13, 2019

@eshiol yes this makes sense please add it to this PR too.

@zero-24
Copy link
Member

zero-24 commented Aug 18, 2019

I have tested this item ✅ successfully on 5fe0f34

works good to me thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25829.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 5fe0f34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25829.

@ghost
Copy link

ghost commented Aug 19, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 19, 2019
@HLeithner
Copy link
Member

Thank you for bringing GDPR requests to the right persons.

@HLeithner HLeithner merged commit fad260c into joomla:staging Aug 19, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 19, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.12 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants