Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

J!3.2 update , <!DOCTYPE html> missing ? #2649

Closed
pepperstreet opened this issue Dec 5, 2013 · 11 comments
Closed

J!3.2 update , <!DOCTYPE html> missing ? #2649

pepperstreet opened this issue Dec 5, 2013 · 11 comments
Labels
No Code Attached Yet

Comments

@pepperstreet
Copy link

Just noticed a very strange difference in two J!3.2 test installations. One is an updated site from 3.1.x and the other is a full installation.

The visual issue is a wrong height for all standard input fields in frontend. i.e. only 20px, without any padding. Bootstrap default is much bigger by default.

I thought it might be related to the template CSS... and i tested different templates and frameworks. The input height did not change. Then I switched to the second J!3.2 installation, and the input height was back to normal, i.e. bootstrap2 default. No matter which template or framework I choose.

So, the difference is visible in the updated site only.
Coincidentally, i noticed in Firebug inspector that the DOCTYPE is missing!?

  • DOCTYPE is missing in updated site only.
  • Missing DOCTYPE seems to be the cause for different CSS rendering.
  • The J!3.2 full installation has no issues. DOCTYPE is present!

Anyone seen this before?
Thanks in advance.
@Bakual
Copy link
Contributor

Bakual commented Dec 5, 2013

That doesn't make much sense to me. The <!DOCTYPE html> should be generated by the template itself, not by Joomla. See https://github.com/joomla/joomla-cms/blob/master/templates/beez3/index.php#L71 and https://github.com/joomla/joomla-cms/blob/master/templates/protostar/index.php#L82 for the lines in Beez and Protostar respectively.
Can you check the index.php file in your template for the presence of that (or a similar) line?

I could only imagine that in the updated version, a plugin messes around with that somehow.

@pepperstreet
Copy link
Author

Thanks for your quick reply. Exactly my first thoughts, too.
Frankly, I really hesitated to post this issue at all… because of its strangeness ;-)
At the moment, I am clueless… but I will check this again!
As far as I recall it, it happens in J! default templates, too.

(I am currently on a different machine, stay tuned...)

@Bakual
Copy link
Contributor

Bakual commented Dec 6, 2013

Maybe also check if it's a caching issue 😄

@pepperstreet
Copy link
Author

BTW, i found 1! similar report by a german user. Upgrade to J!3.2 and it seems he use a commercial template based on foundation framework. The post is here, but in german: http://www.seitenreport.de/forum/beitraege/analyse_ergebnisse/komplette_fehlermeldung_nach_update_auf_joomla_32.html

@Bakual
Copy link
Contributor

Bakual commented Dec 6, 2013

German isn't an issue for me, being from german part in Switzerland 😃
I read the thread but didn't get much enlightment out of it.
Going forward you should open a tracker item on our issue tracker http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103 since we are not yet tracking issues in GitHub.
Provide testing instructions to reproduce it as best as you can. That will certainly help.

If the tracker item exists, you can reference it back here.

@Webdongle
Copy link
Contributor

@Bakual

Just posting in here to test as per your request in the cms mailing list. Sorry about making an off topic post
You may blame the J!Tracker Application for transmitting this comment.

@wilsonge
Copy link
Contributor

wilsonge commented Dec 9, 2013

I've got a 3.2 site I've been working on a template for and I can see the doctype fine if I look in the source

@pepperstreet
Copy link
Author

Sorry, but I couldn't re-create this strange behavior in a new (3rd) installation. I used the same packages, extensions and templates etc.

I also tried to compare the working 3.2 full install vs. 3.1.5updated site. Disabled and moved system plugins etc. etc. No succese, no difference...

Now the funny part:
I re-installed a 3.2 FULL installation over the site with DOCTYPE issues... also re-installed K2 (because it seems to add special HTML prefix stuff in the head). Then I manually copied PROTOSTAR template to my updates site...

and the DOCTYPE is there again! :D

Please, don´t ask what was the final culprit and cause!?! I don't know.

@brianteeman
Copy link
Contributor

Does that mean we can close this?

@pepperstreet
Copy link
Author

@brianteeman
Probably, yes.
(I wish I could give more details about the actual cause and solution, sorry. I will keep an eye on that test installation)

@brianteeman
Copy link
Contributor

Closing for now. If you have more information in the future it can always be reopened

infograf768 added a commit to infograf768/joomla-cms that referenced this issue Nov 2, 2019
@infograf768
[4.0] Fixing switcher label joomla#2649
fe97446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Bakual @Webdongle @pepperstreet @brianteeman @wilsonge @zero-24