Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] No jQuery #26584

Merged
merged 2 commits into from
Oct 13, 2019
Merged

[4.0] No jQuery #26584

merged 2 commits into from
Oct 13, 2019

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Oct 13, 2019

Pull Request for Issue # .

Summary of Changes

Remove jQuery dependency from com_actionlogs admin view

Testing Instructions

Go to administrator/index.php?option=com_actionlogs
Check if the buttons Export Selected as CSV and Export All as CSV work correctly

Expected result

Actual result

Documentation Changes Required

No, removed unneeded dependency

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Oct 13, 2019
@richard67
Copy link
Member

I have tested this item ✅ successfully on 5acdf71


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26584.

@Quy
Copy link
Contributor

Quy commented Oct 13, 2019

For Export Selected as CSV button, here is the message There are no User Action logs to export.

@richard67
Copy link
Member

@Quy Did you do npm and clear broswer cache? I had that too but with npm and cleared cache it was ok.

@Quy
Copy link
Contributor

Quy commented Oct 13, 2019

I have tested this item ✅ successfully on 5acdf71


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26584.

@Quy
Copy link
Contributor

Quy commented Oct 13, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26584.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 13, 2019
@wilsonge wilsonge merged commit 0bb0662 into joomla:4.0-dev Oct 13, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 13, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 13, 2019
@dgrammatiko dgrammatiko deleted the 4.0-dev-no-jquery-com_actionlogs branch October 14, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants