Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [com_contenthistory] Add check for real null datetimes #26777

Merged

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Oct 23, 2019

Pull Request for Issue # .

Summary of Changes

This is a follow up to recently merged PR's which changed datetime columns in database for real null values.

Because content history might be used not only for core components' database tables, the checks for the old (preudo-)null datetimes are kept and extended by the check for real null values.

The PR makes sure that in the comparison and preview models, no datetime formatting is done with null values.

Testing Instructions

Code review should be sufficient: Make sure that in com_contenthistory there are no other places where old (preudo-)null datetimes are checked without checking for real null values, too.

Expected result

Datetime values which have real null values in database are shown as emtpy and not as any rubbish date.

Actual result

Datetime values which have real null values in database might be shown as some rubbish date or lead to formatting errors.

Documentation Changes Required

None.

@richard67 richard67 changed the title [4.0] [WiP] [com_contenthistory] Add check for real null datetimes [4.0] [com_contenthistory] Add check for real null datetimes Oct 23, 2019
@richard67 richard67 marked this pull request as ready for review October 23, 2019 16:55
@richard67
Copy link
Member Author

Drone failure seems to be unrelated.

@Quy
Copy link
Contributor

Quy commented Oct 26, 2019

I have tested this item ✅ successfully on e494e80


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26777.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on e494e80

By review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26777.

@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26777.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 27, 2019
@wilsonge wilsonge merged commit a7e70a2 into joomla:4.0-dev Nov 3, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Nov 3, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 3, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Nov 3, 2019
@richard67 richard67 deleted the 4.0-dev-com-contenthistory-null-date branch November 3, 2019 11:30
@richard67
Copy link
Member Author

Thanks too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants