-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] [com_contenthistory] Add check for real null datetimes #26777
Merged
wilsonge
merged 5 commits into
joomla:4.0-dev
from
richard67:4.0-dev-com-contenthistory-null-date
Nov 3, 2019
Merged
[4.0] [com_contenthistory] Add check for real null datetimes #26777
wilsonge
merged 5 commits into
joomla:4.0-dev
from
richard67:4.0-dev-com-contenthistory-null-date
Nov 3, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drone failure seems to be unrelated. |
I have tested this item ✅ successfully on e494e80 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26777. |
I have tested this item ✅ successfully on e494e80 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26777. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26777. |
Thanks! |
Thanks too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This is a follow up to recently merged PR's which changed datetime columns in database for real null values.
Because content history might be used not only for core components' database tables, the checks for the old (preudo-)null datetimes are kept and extended by the check for real null values.
The PR makes sure that in the comparison and preview models, no datetime formatting is done with null values.
Testing Instructions
Code review should be sufficient: Make sure that in com_contenthistory there are no other places where old (preudo-)null datetimes are checked without checking for real null values, too.
Expected result
Datetime values which have real null values in database are shown as emtpy and not as any rubbish date.
Actual result
Datetime values which have real null values in database might be shown as some rubbish date or lead to formatting errors.
Documentation Changes Required
None.