Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Move options from grid to column layout #27141

Merged
merged 4 commits into from
Nov 25, 2019

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Nov 24, 2019

Pull Request for Issue #27136.

Summary of Changes

This PR creates some column-count classes and applies them to the joomla.edit.params layout.

Basically means that fields get ordered vertically (J3) instead of horizontally which is the case when using grid.

If this gets merged then I will apply on all other forms.

Testing Instructions

Apply this patch and run node build.js --compile-css for updating the changed SCSS. Alternatively, you can run npm i.

Navigate to article edit -> Options tab

Before PR

o4grXhrkUc

WIth PR

iydq12lHd0

Documentation Changes Required

@brianteeman
Copy link
Contributor

THANK YOU

@Quy
Copy link
Contributor

Quy commented Nov 24, 2019

Go to Content >Categories
Edit Uncategorised
Go to Options
Select is in the next column

27141

@ciar4n
Copy link
Contributor Author

ciar4n commented Nov 24, 2019

Thx @Quy. That should be ok now.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on c746736


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27141.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Nov 24, 2019

I have tested this item ✅ successfully on c746736


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27141.

@Quy
Copy link
Contributor

Quy commented Nov 24, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27141.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 24, 2019
@Quy Quy removed the RTC This Pull Request is Ready To Commit label Nov 24, 2019
@Quy
Copy link
Contributor

Quy commented Nov 24, 2019

Administrator Template Styles > autum > Image Settings

27141a

@ciar4n
Copy link
Contributor Author

ciar4n commented Nov 24, 2019

@Quy Should be ok now. XML update so no need to recompile css.

@Quy
Copy link
Contributor

Quy commented Nov 24, 2019

If this gets merged then I will apply on all other forms.

Is this related to my last comment?

The before and after look differently. Is this the expected behavior?

27141-before

27141-after

@ciar4n
Copy link
Contributor Author

ciar4n commented Nov 25, 2019

Is this related to my last comment?

There is another 60+ files that use the current grid based forms. A follow-up PR would apply the changes here across all such files and remove the old grid based forms CSS. The Atum XML from your last comment was created for the grid based forms so the field order was different. Most XMLs have been created with the column based forms used in Joomla 3 and therefore should be better suited to the changes here.

The before and after look differently. Is this the expected behavior?

Yes. There will be differences. Currently, forms are placed in a grid so forms are inline with each other both vertically and horizontally. This PR changes forms to a column layout.

Grid layout...

image

Column layout...

image

Look at any multi-column form outside of Joomla and they will always be in a column layout and read vertically, never a grid.

@wilsonge wilsonge merged commit a1dfde5 into joomla:4.0-dev Nov 25, 2019
@wilsonge
Copy link
Contributor

Thanks @ciar4n happy to move onto doing this elsewhere

@wilsonge wilsonge added this to the Joomla 4.0 milestone Nov 25, 2019
@ciar4n
Copy link
Contributor Author

ciar4n commented Nov 25, 2019

Thank you for the tests.

@ciar4n
Copy link
Contributor Author

ciar4n commented Jan 17, 2020

To complete I need some tests on #27141. Otherwise, this should be reverted.

@wilsonge
Copy link
Contributor

That got merged two months ago?

@ciar4n
Copy link
Contributor Author

ciar4n commented Jan 18, 2020

Ah sorry .. wrong pr... this one.. #27153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants