-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Move options from grid to column layout #27141
Conversation
THANK YOU |
Thx @Quy. That should be ok now. |
I have tested this item ✅ successfully on c746736 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27141. |
1 similar comment
I have tested this item ✅ successfully on c746736 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27141. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27141. |
@Quy Should be ok now. XML update so no need to recompile css. |
There is another 60+ files that use the current grid based forms. A follow-up PR would apply the changes here across all such files and remove the old grid based forms CSS. The Atum XML from your last comment was created for the grid based forms so the field order was different. Most XMLs have been created with the column based forms used in Joomla 3 and therefore should be better suited to the changes here.
Yes. There will be differences. Currently, forms are placed in a grid so forms are inline with each other both vertically and horizontally. This PR changes forms to a column layout. Grid layout...Column layout...Look at any multi-column form outside of Joomla and they will always be in a column layout and read vertically, never a grid. |
Thanks @ciar4n happy to move onto doing this elsewhere |
Thank you for the tests. |
To complete I need some tests on #27141. Otherwise, this should be reverted. |
That got merged two months ago? |
Ah sorry .. wrong pr... this one.. #27153 |
Pull Request for Issue #27136.
Summary of Changes
This PR creates some column-count classes and applies them to the
joomla.edit.params
layout.Basically means that fields get ordered vertically (J3) instead of horizontally which is the case when using grid.
If this gets merged then I will apply on all other forms.
Testing Instructions
Apply this patch and run node build.js --compile-css for updating the changed SCSS. Alternatively, you can run npm i.
Navigate to article edit -> Options tab
Before PR
WIth PR
Documentation Changes Required