Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Switch remaining options from grid to column layout #27153

Merged
merged 9 commits into from
Jan 18, 2020

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Nov 26, 2019

Pull Request for Issue #27136.

Summary of Changes

This PR applies #27141 to the remaining forms.

Testing Instructions

Apply this patch and run node build.js --compile-css for updating the changed SCSS.

Ensure options column layout is correct. The majority of this PR effects the Global Configuration form layout. For details on these changes, take look at #27141.

@Quy
Copy link
Contributor

Quy commented Nov 26, 2019

Fieldset/legend not styled.

BEFORE:
27153-before

AFTER:
27153-after

@ciar4n
Copy link
Contributor Author

ciar4n commented Nov 26, 2019

Fieldset/legend not styled.

@Quy I am unable to replicate this. Full refresh after compiling?

@Quy
Copy link
Contributor

Quy commented Nov 26, 2019

Installed your branch and it is fine. Yes, full refresh after compiling. I must have done something wrong. Thanks.

@Quy
Copy link
Contributor

Quy commented Nov 26, 2019

Will the following be one column? I see that this is the case with Configure Edit Screen.

27153-options

@ciar4n
Copy link
Contributor Author

ciar4n commented Nov 26, 2019

My personal preference would be all one column but it was not my intent here to change that. It looks like I missed the Configure Edit Screen tab.

@ciar4n
Copy link
Contributor Author

ciar4n commented Nov 26, 2019

I have moved the Configure Edit Screen to 3 columns as before.

@Quy
Copy link
Contributor

Quy commented Nov 26, 2019

That would be my preference too as I find it disorienting in columns as mentioned in ##25891.

@Quy
Copy link
Contributor

Quy commented Nov 26, 2019

Table not full width under Global Configuration > Permissions.

27153-permissions

@brianteeman
Copy link
Contributor

that one is a special case iirc and has a class specified administrator\components\com_config\tmpl\application\default_permissions.php

@ciar4n
Copy link
Contributor Author

ciar4n commented Nov 27, 2019

Thank you. It should be ok now.

@Quy
Copy link
Contributor

Quy commented Nov 27, 2019

Debug Language moves depending on the selection. Is this beyond the scope of this PR?
When Yes, it is in the first column.
When No, it is in the second column.

debug-on

debug-off

PS: Global Configuration differs from the other Components' settings by having 2 columns vs 1 column.

@ciar4n
Copy link
Contributor Author

ciar4n commented Nov 28, 2019

Thanks @Quy. I'll have a look in to this in the morning.

@ciar4n
Copy link
Contributor Author

ciar4n commented Nov 28, 2019

Debug Language moves depending on the selection.

Debug fields re-ordered to amend this issue..

c51JcHZx4X

@Quy
Copy link
Contributor

Quy commented Nov 29, 2019

Sorry another one with Connection Encryption:

27153-database-1way

27153-database-2way

@ciar4n
Copy link
Contributor Author

ciar4n commented Dec 16, 2019

Sry @Quy.. I'd forgotten about this.

Currently no way around stopping the jump here. The column-count CSS property, by default, evenly splits content across the set number of columns.. Because this show-on adds so many new fields, some of the fields will always jump to the first column.

AFAIK we can not set the break point (spec.. https://drafts.csswg.org/css-multicol-1/#cc). Even if we can, I suspect #27165 will be an issue

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 11a3af8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27153.

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 1e661b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27153.

@infograf768
Copy link
Member

It does no solve #27490

@wilsonge wilsonge merged commit c99193e into joomla:4.0-dev Jan 18, 2020
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 18, 2020
@wilsonge
Copy link
Contributor

Sorry for missing this when it first came in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants