-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Switch remaining options from grid to column layout #27153
Conversation
@Quy I am unable to replicate this. Full refresh after compiling? |
Installed your branch and it is fine. Yes, full refresh after compiling. I must have done something wrong. Thanks. |
My personal preference would be all one column but it was not my intent here to change that. It looks like I missed the |
I have moved the |
That would be my preference too as I find it disorienting in columns as mentioned in ##25891. |
that one is a special case iirc and has a class specified |
Thank you. It should be ok now. |
Thanks @Quy. I'll have a look in to this in the morning. |
Sry @Quy.. I'd forgotten about this. Currently no way around stopping the jump here. The column-count CSS property, by default, evenly splits content across the set number of columns.. Because this show-on adds so many new fields, some of the fields will always jump to the first column. AFAIK we can not set the break point (spec.. https://drafts.csswg.org/css-multicol-1/#cc). Even if we can, I suspect #27165 will be an issue |
I have tested this item ✅ successfully on 11a3af8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27153. |
I have tested this item ✅ successfully on 1e661b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27153. |
It does no solve #27490 |
Thanks! |
Sorry for missing this when it first came in |
Pull Request for Issue #27136.
Summary of Changes
This PR applies #27141 to the remaining forms.
Testing Instructions
Apply this patch and run
node build.js --compile-css
for updating the changed SCSS.Ensure options column layout is correct. The majority of this PR effects the Global Configuration form layout. For details on these changes, take look at #27141.