Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Installation. Misleading de-DE alert text #27306

Closed
ReLater opened this issue Dec 18, 2019 · 6 comments
Closed

[3] Installation. Misleading de-DE alert text #27306

ReLater opened this issue Dec 18, 2019 · 6 comments

Comments

@ReLater
Copy link
Contributor

ReLater commented Dec 18, 2019

I really don't know if it's worth to change something here. Pedantry...

Steps to reproduce the issue

  • Install J3 and set language to de-DE for install process.
  • In databse settings fill all fields but clear the table prefix field.
  • Try to go to next installation step.

You'll see an alert (language string INSTL_DATABASE_PREFIX_MSG) that says:

Der Tabellenpräfix muss mit einem Buchstaben beginnen, danach können optional alphanumerische Zeichen und ein Unterstrich folgen.

(EN counterpart:
The table prefix must start with a letter, be followed by optional alphanumeric characters and by an underscore
)

  • At least the German text suggests that the underscore is optional, too.
@brianteeman
Copy link
Contributor

@Bakual one for you

@zero-24
Copy link
Contributor

zero-24 commented Dec 18, 2019

@ReLater hmm I'm not an regex pro but it does not seam to be required:

if (!preg_match('#^[a-zA-Z]+[a-zA-Z0-9_]*$#', $options->db_prefix))

Demo
https://3v4l.org/SD0XE

@ReLater
Copy link
Contributor Author

ReLater commented Dec 18, 2019

It's required. I've tested it without underscore.

See also description of the related input field: https://github.com/joomla/joomla-cms/blob/staging/installation/language/de-DE/de-DE.ini#L44

enthält nur alphanumerische Zeichen und MUSS mit einem Unterstrich enden.

I think it's a JS thing or client-site input validation but ???.

@zero-24
Copy link
Contributor

zero-24 commented Dec 18, 2019

Well than please send an issue / PR against https://github.com/joomlagerman/joomla so we make it more clear that the underscore is required in that string too. Any changes in the official language repo gets synced back in here.

@ReLater
Copy link
Contributor Author

ReLater commented Dec 18, 2019

PR: joomlagerman/joomla#847

@ReLater ReLater closed this as completed Dec 18, 2019
@zero-24
Copy link
Contributor

zero-24 commented Dec 18, 2019

Thanks @ReLater

tecpromotion added a commit to tecpromotion/joomla-cms that referenced this issue Dec 19, 2019
references the PR for the issue joomla#27306
zero-24 pushed a commit that referenced this issue Dec 19, 2019
references the PR for the issue #27306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants