clarification of the return value for the user ID

[tecpromotion]

Summary of Changes

To make it clear what the returned number is. It is the user ID. There was some confusion about this in the German language files, and some site operators asked for the unit and thought it was days.

With this change, the username is returned as suggested and the super user is notified.

Testing Instructions

.

Expected result

.

Actual result

.

Documentation Changes Required

[ChristineWk]

I have tested this item ✅ successfully on 00955a9

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27374.}

[brianteeman]

Would it not be better to keep the language string the same and to change the id to username

joomla-cms/plugins/system/privacyconsent/privacyconsent.php

Line 703 in 8f40198

JText::sprintf('PLG_SYSTEM_PRIVACYCONSENT_NOTIFICATION_USER_PRIVACY_EXPIRED_MESSAGE', $user->user_id)

[tecpromotion]

Would it not be better to keep the language string the same and to change the id to username

I've been thinking about that, too. Especially because we (almost) always use the user name in the action logs.

[richard67]

Would it not be better to keep the language string the same and to change the id to username

I've been thinking about that, too. Especially because we (almost) always use the user name in the action logs.

Agree.

[zero-24]

			$messageModel->notifySuperUsers(
				JText::_('PLG_SYSTEM_PRIVACYCONSENT_NOTIFICATION_USER_PRIVACY_EXPIRED_SUBJECT'),
				JText::sprintf(
					'PLG_SYSTEM_PRIVACYCONSENT_NOTIFICATION_USER_PRIVACY_EXPIRED_MESSAGE',
					JFactory::getUser($user->user_id)->username
				)
			);

https://github.com/joomla/joomla-cms/blob/staging/plugins/system/privacyconsent/privacyconsent.php#L701-L704

This should do the trick. cc @tecpromotion

[tecpromotion]

@brianteeman I have withdrawn the adjustment of the language string and as suggested committed the username as return value. Many thanks to @zero-24 and @richard67

[Quy]

I have tested this item ✅ successfully on 65407b6

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27374.}

[alikon]

I have tested this item ✅ successfully on 65407b6

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27374.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27374.}

[zero-24]

Merging + cc for @imanickam @infograf768 to check whether this can / should / need to be communicated to the TT's

Thanks @tecpromotion