[4.0] Drag n Drop Images in TinyMCE kills site

[brianteeman]

Well not exactly kills it but it will do eventually

In Joomla 3 a drag and drop image plugin was added so that you could add images to your content more easily and the images would be saved automatically in a specified folder on your server.

In Joomla 4 that isnt working at all

Instead the native tinymce drag and drop image is used. This is a problem because this saves the image as a base64 blob in the database. Obviously this is not desirable as a user uploading a large image will see it take a long time to save the article and very quickly the database will get huge. It is also really slow to render an image this way.

[richard67]

@brianteeman Do you think this is a release blocker? To me it seems it could be one.

[jwaisner]

I would say this is a release blocker. We definitely don't want to impact DB performance as well as size if it is being loaded this way.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27477.}

[HLeithner]

@bembelimen is this a regression of the tinymce 4.0 update? Can you have a look at this?

[infograf768]

Setting as release blocker

[brianteeman]

Setting paste_data_images to false will prevent this happening but it still wont fix the non working joomla drag and drop plugin

[bembelimen]

There are several reasons for this broken behavior:

• Plugin is called "jdragndrop" (https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/editors/tinymce/tinymce.php#L508) but the real name is "jdragdrop" (https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/plg_editors_tinymce/js/plugins/dragdrop/plugin.es6.js#L2)
• TinyMCE has an own uploader, which has to be overwritten (https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/editors/tinymce/tinymce.php#L531-L533 + https://www.tiny.cloud/docs/configure/file-image-upload/) or probably we don't need such a plugin.
• com_media changes its API completly in J! 4 (https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/editors/tinymce/tinymce.php#L513), so the call is wrong, also the return value.

[Fedik]

ah, okay, I see

joomla-cms/administrator/components/com_media/src/Controller/ApiController.php

Lines 26 to 29 in 24265b1

	* Api Media Controller
	*
	* This is NO public api controller, it is internal for the com_media component only!
	*

[Fedik]

To be able to fix this issue someone need to write an upload handler.
Or we just copy old one? https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_media/controllers/file.json.php 😃

[brianteeman]

Seriously - the all singing all dancing new media manager doesnt have an upload handler

rm -rf /com_media

npm i upploadjs.org

https://uppload.js.org

[Fedik]

Seriously - the all singing all dancing new media manager doesnt have an upload handler

I had similar thoughts 😄

[dgrammatiko]

I'll post a patch tomorrow

[dgrammatiko]

PR: #28928

[richard67]

@dgrammatiko Shall I close this issue because there is PR #28928 ?

[dgrammatiko]

Yes😉

[richard67]

Closing as having PR, see above.