Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] TinyMCE context menu #27497

Merged
merged 3 commits into from
Jan 16, 2020
Merged

[4.0] TinyMCE context menu #27497

merged 3 commits into from
Jan 16, 2020

Conversation

brianteeman
Copy link
Contributor

Tinymce has an option in the plugin called Context Menu but it doesn't do anything as there is no code to do anything.

With this PR you can no disable/enable the ability to right click on an item in the editor and get a contextual menu. When this is disabled you get the context menu from your browser

Enabled

image

Disabled

image

Testing

Make sure that you set the option to be enabled/disabled in the correct set. Default for a super user is set 0

Tinymce has an option in the plugin called Context Menu but it doesn't do anything as there is no code to do anything.

With this PR you can no disable/enable the ability to right click on an item in the editor and get a contextual menu. When this is disabled you get the context menu from your browser

### Testing
Make sure that you set the option to be enabled/disabled in the correct set. Default for a super user is set 0

### Additional Note
This is also broken in Joomla 3
@Quy
Copy link
Contributor

Quy commented Jan 12, 2020

I have tested this item ✅ successfully on 0ca3a10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27497.

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 0ca3a10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27497.

@Quy
Copy link
Contributor

Quy commented Jan 15, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27497.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 15, 2020
@HLeithner HLeithner merged commit 8eb2209 into joomla:4.0-dev Jan 16, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 16, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Jan 16, 2020
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the saturday4 branch January 16, 2020 13:17
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants