-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] TinyMCE context menu #27497
Merged
Merged
[4.0] TinyMCE context menu #27497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinymce has an option in the plugin called Context Menu but it doesn't do anything as there is no code to do anything. With this PR you can no disable/enable the ability to right click on an item in the editor and get a contextual menu. When this is disabled you get the context menu from your browser ### Testing Make sure that you set the option to be enabled/disabled in the correct set. Default for a super user is set 0 ### Additional Note This is also broken in Joomla 3
This reverts commit 7e187d0.
I have tested this item ✅ successfully on 0ca3a10 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27497. |
Fedik
reviewed
Jan 12, 2020
I have tested this item ✅ successfully on 0ca3a10 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27497. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27497. |
Thanks |
Thanks |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tinymce has an option in the plugin called Context Menu but it doesn't do anything as there is no code to do anything.
With this PR you can no disable/enable the ability to right click on an item in the editor and get a contextual menu. When this is disabled you get the context menu from your browser
Enabled
Disabled
Testing
Make sure that you set the option to be enabled/disabled in the correct set. Default for a super user is set 0