Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] I deleted a line that I don't think we need. #27772

Merged
merged 2 commits into from Feb 5, 2020

Conversation

astridx
Copy link
Contributor

@astridx astridx commented Feb 2, 2020

Summary of Changes

I deleted a line that I don't think we need.

Testing Instructions

Code review
or create a contact and check the default view in front end.

@richard67
Copy link
Member

@astridx Your PR seems to be correct, I can't see that variable being used somewhere. But in J3 we have the same in file components/com_contact/views/contact/tmpl/default.php, line 14. Question is: Should this be fixed in J3 (staging) ald later be merged up into 4.0-dev? @wilsonge What do you suggest?

@mbabker
Copy link
Contributor

mbabker commented Feb 2, 2020

Should this be fixed in J3 (staging) ald later be merged up into 4.0-dev?

A bug in 3.x should be fixed in 3.x and merged to 4.0. You don't fix known 3.x bugs only in 4.0 without good reason.

@richard67
Copy link
Member

A bug in 3.x should be fixed in 3.x and merged to 4.0. You don't fix known 3.x bugs only in 4.0 without good reason.

That's why I've asked. Not on me to decide though because it's not my PR.

@mbabker
Copy link
Contributor

mbabker commented Feb 2, 2020

If the project's support stance is not "bugs should be fixed in the lowest supported version applicable" then the project's support stance is FUBAR.

The project should not be incentivizing use of J4 by saying "oh, by the way, we fixed a bunch of bugs in 3.x in 4.0 without backporting those fixes even though we totally could".

@toivo
Copy link
Contributor

toivo commented Feb 4, 2020

I have tested this item ✅ successfully on 7e4c89e

Tested in Feb 4, 2020 Nightly build and PHP 7.4.2 on localhost using Wampserver


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27772.

@Quy
Copy link
Contributor

Quy commented Feb 4, 2020

I have tested this item ✅ successfully on 84077b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27772.

@Quy
Copy link
Contributor

Quy commented Feb 5, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27772.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 5, 2020
@Quy Quy merged commit f3167c2 into joomla:4.0-dev Feb 5, 2020
@Quy Quy added this to the Joomla 4.0 milestone Feb 5, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 5, 2020
@astridx astridx deleted the cscontactdefault branch August 9, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants