New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] I deleted a line that I don't think we need. #27772
Conversation
@astridx Your PR seems to be correct, I can't see that variable being used somewhere. But in J3 we have the same in file |
A bug in 3.x should be fixed in 3.x and merged to 4.0. You don't fix known 3.x bugs only in 4.0 without good reason. |
That's why I've asked. Not on me to decide though because it's not my PR. |
If the project's support stance is not "bugs should be fixed in the lowest supported version applicable" then the project's support stance is FUBAR. The project should not be incentivizing use of J4 by saying "oh, by the way, we fixed a bunch of bugs in 3.x in 4.0 without backporting those fixes even though we totally could". |
I have tested this item ✅ successfully on 7e4c89e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27772. |
I have tested this item ✅ successfully on 84077b2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27772. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27772. |
Summary of Changes
I deleted a line that I don't think we need.
Testing Instructions
Code review
or create a
contact
andcheck
thedefault view
in front end.