Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Alias description #28466

Merged
merged 1 commit into from
Mar 27, 2020
Merged

[4.0] Alias description #28466

merged 1 commit into from
Mar 27, 2020

Conversation

brianteeman
Copy link
Contributor

As requested by @wilsonge this PR displays a simple description for the alias fields.

image

As requested by @wilsonge this PR displays a simple description for the alias fields.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Mar 26, 2020
@richard67
Copy link
Member

I have tested this item ✅ successfully on acb8863

1. Code review: New description is added everywhere, where label "JFIELD_ALIAS_LABEL" is used, i.e. no alias field was forgotten.
2. Real test with backend: Looks nice and reads short and precise.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28466.

@@ -169,7 +169,7 @@ JERROR_USERS_PROFILE_NOT_FOUND="User profile not found"

JFIELD_ACCESS_DESC="Access level for this content."
JFIELD_ACCESS_LABEL="Access"
JFIELD_ALIAS_DESC="The Alias will be used in the SEF URL. Leave this blank and Joomla! will fill in a default value from the title. This value will depend on the SEO settings (Global Configuration->Site). <br>Using Unicode will produce UTF-8 aliases. You may also enter manually any UTF-8 character. Spaces and some forbidden characters will be changed to hyphens.<br>When using default transliteration it will produce an alias in lower case and with dashes instead of spaces. You may enter the Alias manually. Use lowercase letters and hyphens (-). No spaces or underscores are allowed. Default value will be a date and time if the title is typed in non-latin letters ."
JFIELD_ALIAS_DESC="The Alias will be used as part of the URL."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to a docs page with more info like wordpress does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that but chose not too. There is already a help button on the page.

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on acb8863


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28466.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators PR-4.0-dev labels Mar 26, 2020
@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28466.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 26, 2020
@zero-24 zero-24 added the Language Change This is for Translators label Mar 26, 2020
@Quy Quy added the PR-4.0-dev label Mar 26, 2020
@zero-24 zero-24 added this to the Joomla 4.0 milestone Mar 27, 2020
@zero-24 zero-24 merged commit 5d07e26 into joomla:4.0-dev Mar 27, 2020
@zero-24
Copy link
Contributor

zero-24 commented Mar 27, 2020

Merging thanks 👍

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2020
@brianteeman
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants