New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] send emails to dotless domains #28576
Conversation
Now that we are using phpmailer 6'+ this code block is not needed as it is now the default. However it does not support dotless domains which joomla supports so we still need to set a validator. this is a backport of joomla#28574 technically this pr is a b/c break as it allows dotless domains and it has not allowed allowed dotless domains since joomla#24726 was merged but its much more of a bug fix as we should have allowed dotless domains and that pr broke it
I am not sure if I understand this well, but AFAIK, 3.9.17 will use PHPMailer 5.2.28, right? |
shoot I didnt check. i just saw that 5.2 was not supported by phpmailer even for security and incorrectly assumed we had therefore updated. However that misassumption doesnt change the need for this pr or invalidate the changes. I will update the original post |
I have tested this item ✅ successfully on 09960ab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28576. |
Could this, as well as #28574 have an impact on utf8 domains? |
Test it and see |
I have tested this item ✅ successfully on 09960ab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28576. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28576. |
@zero-24 any reason this hasnt been merged? |
I'm waiting for this test. |
there is no reason for it to fail. the html5 validate really just checks for something@something or something@something.tld unlike the php version which doesnt test for the first using utf8 or punycode doesnt introduce any . or @ as that would obviously break all email so there is no reason it could fail |
You requested the test not me. So I assume it's working. thanks |
thanks |
this is a backport of joomla#28574
Now that we are using phpmailer 6'+ this code block is not needed as it is now the default. However it does not support dotless domains which joomla supports so we still need to set a validator.It was an error to change from using auto to php for email address validation as the php validation does not support dotless domains which joomla supports so we have to use html5 as the validator.
this is a backport of #28574
technically this pr is a b/c break as it allows dotless domains and it has not allowed allowed dotless domains since #24726 was merged but its much more of a bug fix as we should have allowed dotless domains and that pr broke it
Testing Instructions
see #28574