Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Add extension name/id to uninstall message if extension is locked, redo of PR 28916 #28960

Merged
merged 2 commits into from
May 6, 2020

Conversation

richard67
Copy link
Member

@richard67 richard67 commented May 6, 2020

Pull Request for Issue # .

Summary of Changes

This is a redo of PR #28916 . Thanks @ReLater for the implementation.

  • Change lang string COM_INSTALLER_UNINSTALL_ERROR_LOCKED_EXTENSION.
  • Use sprintf to display extension name and id.

Testing Instructions

  • 4.0 nightly build of today (Wednesday, 06 May 2020) or later.
  • Go to extensions manager (administrator/index.php?option=com_installer&view=manage).
  • Select many locked extensions.
  • Click Uninstall and check the messages at the top.
  • CLI: Use php cli/joomla.php extension:remove xxx, with xxxbeing an extension ID for a locked core extension, e.g. Action Log - Joomla.

Actual result

In backend in extensions manage:
03-05-_2020_14-23-04

CLI:
pr-28960_before_cli

Expected result after applying PR

In backend in extensions manage:
pr-28960_after_backend

CLI:
pr-28960_after_cli

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels May 6, 2020
@richard67 richard67 marked this pull request as ready for review May 6, 2020 08:37
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 580ff13


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28960.

@richard67
Copy link
Member Author

richard67 commented May 6, 2020

@ChristineWk Please test.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 580ff13


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28960.

@infograf768 infograf768 removed Language Change This is for Translators PR-4.0-dev labels May 6, 2020
@infograf768
Copy link
Member

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28960.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 6, 2020
@infograf768 infograf768 added this to the Joomla 4.0 milestone May 6, 2020
@infograf768 infograf768 merged commit baffbcb into joomla:4.0-dev May 6, 2020
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels May 6, 2020
@infograf768
Copy link
Member

Tks to both

@richard67 richard67 deleted the 4.0-dev-redo-pr-28916 branch May 6, 2020 09:30
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants