Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] TinyMCE not saving #29351

Merged
merged 5 commits into from
Jun 1, 2020
Merged

[4.0] TinyMCE not saving #29351

merged 5 commits into from
Jun 1, 2020

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented May 31, 2020

Pull Request for Issue #26579 . (release blocker)

Summary of Changes

  • Some JS magic (not really)
  • remove the inline js from the toggle button

Testing Instructions

Create an article
Toggle to html editor and add some code, e.g.

<div style="border: 1px solid red; padding: 10px;">
    <div style="border: 1px solid blue; padding: 10px;">Some text here</div>
</div>

(Without toggling Editor) Click/tap 'Save'

Expected result

Save the correct content

Actual result

Saves the wrong content (uses the content that existed before switching to naked)

Documentation Changes Required

NO

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 31, 2020
@joomla-cms-bot joomla-cms-bot removed the Language Change This is for Translators label May 31, 2020
@richard67
Copy link
Member

I have tested this item ✅ successfully on b1f9734


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29351.

@dgrammatiko
Copy link
Contributor Author

An update here: the second commit is cleaning up the initialisation a bit and it's confirmed solution from the tinyMCE authors: tinymce/tinymce#5712 (comment)

@richard67
Copy link
Member

@dgrammatiko Just am preparing for testing this. Do you plan any further changes for which I should wait?

@dgrammatiko
Copy link
Contributor Author

@richard67 no more tweaks then, go ahead

@richard67
Copy link
Member

I have tested this item ✅ successfully on 0d502f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29351.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 1, 2020

I have tested this item ✅ successfully on 0d502f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29351.

@Quy
Copy link
Contributor

Quy commented Jun 1, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29351.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 1, 2020
@wilsonge wilsonge merged commit 97db51b into joomla:4.0-dev Jun 1, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Jun 1, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 1, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 1, 2020
@dgrammatiko dgrammatiko deleted the 4.0-tinyError branch June 1, 2020 23:01
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants